Add info-level logging to all MCP tools#250
Conversation
|
@claude code review |
|
Claude finished @RafaelPo's task in 48s —— View job Code Review: Add info-level logging to all MCP tools
Verdict: Looks good — clean, consistent, and useful for observability. A few minor notes below.
|
- Log entry params for browse_lists, use_list, progress, results, list_sessions, balance, and cancel (previously only logged on error) - Log success outcomes (result counts, artifact_ids, balance amounts) - Log upload_id + filename on presigned URL request - Log upload_id + size on proxy start, artifact_id on proxy completion - Log proxy error responses with status and body Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Avoids log noise from the tight polling loop (~every 3s). Only logs at INFO when the task reaches a terminal state (completed/failed/revoked). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Uses a module-level set to track which task_ids are being polled.
Logs at INFO on the first call ("polling started") and when the task
reaches a terminal state. Cleans up the set on terminal so re-polling
after a retry still logs correctly.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The in-memory set doesn't work with multiple replicas — different pods don't share state. Instead: log every poll at DEBUG level (invisible at default INFO), log at INFO only on terminal state. Task submission already logs when polling starts implicitly. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
_fetch_task_result returns (df, session_id, artifact_id) but the call site only unpacked 2 values, causing ValueError at runtime every time everyrow_use_list was called. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
New tool added on main was missing info-level logging. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
ca62c69 to
ab701be
Compare
Summary
Tools that gained logging:
everyrow_browse_listseveryrow_use_listeveryrow_progresseveryrow_resultseveryrow_list_sessionseveryrow_balanceeveryrow_cancelTest plan
🤖 Generated with Claude Code