Skip to content

Conversation

@funnel20
Copy link
Contributor

Resolves issue #510

@futuretap
Copy link
Owner

Good idea to support localization for the File parameter. However, we should use IASK's own localization scheme (localizedObjectForKey: instead of NSLocalizedString(). Then the localized URLs are in the same localized string files than the rest of the settings keys.

@funnel20
Copy link
Contributor Author

You're absolutely right, I jumped too fast to conclusions.
Then I need your help a bit, I don't know the exact coding style that you prefer. Or you can make the improvement yourself.

@futuretap
Copy link
Owner

Replacing NSLocalizedString(specifier.file, nil) with [specifier localizedObjectForKey:kIASKFile] should do it.

@funnel20
Copy link
Contributor Author

funnel20 commented Oct 28, 2024

Replacing NSLocalizedString(specifier.file, nil) with [specifier localizedObjectForKey:kIASKFile] should do it.

Done and verified

@futuretap futuretap merged commit cfcc2ac into futuretap:master Oct 29, 2024
@funnel20 funnel20 deleted the WebVC branch October 29, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants