This repository was archived by the owner on Mar 31, 2023. It is now read-only.
Functions for tracking and parsing OVS packet-in message, and sending packet-out message back to OVS. #112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@cj-chung See a conflict in the src/CMakeLists.txt which is likely caused by a recent check-in and the conflict detail could be found at the end of the PR page. We likely need to do a git pull from upstream aca/master and resolve the conflict. |
xieus
reviewed
Jul 5, 2020
| case 'p': | ||
| g_rpc_protocol = optarg; | ||
| break; | ||
| case 'c': |
Contributor
There was a problem hiding this comment.
Let us also update our development instruction https://github.com/futurewei-cloud/alcor-control-agent/blob/master/src/README.md on how to run ACA with those new parameters.
er1cthe0ne
reviewed
Jul 8, 2020
er1cthe0ne
reviewed
Jul 8, 2020
er1cthe0ne
reviewed
Jul 8, 2020
er1cthe0ne
reviewed
Jul 8, 2020
er1cthe0ne
reviewed
Jul 8, 2020
er1cthe0ne
reviewed
Jul 8, 2020
er1cthe0ne
reviewed
Jul 8, 2020
er1cthe0ne
reviewed
Jul 8, 2020
er1cthe0ne
approved these changes
Jul 8, 2020
Contributor
er1cthe0ne
left a comment
er1cthe0ne
left a comment
There was a problem hiding this comment.
Approved per discussion. Please address the needed feedbacks and merge it to master.
Contributor
|
@cj-chung please remove pcapout file and then we can proceed with the merge. And leave any outstanding PR feedback open so that we can address it in the next PR. Thanks. |
zhangml
pushed a commit
to zhangml/alcor-control-agent
that referenced
this pull request
Dec 7, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The features similar to ovs-ofctl utility (ovs-ofctl) are implemented in this PR:
The modified and added files are listed below: