Skip to content
This repository was archived by the owner on Mar 31, 2023. It is now read-only.

Conversation

@zzxgzgz
Copy link
Contributor

@zzxgzgz zzxgzgz commented Mar 25, 2021

This PR proposes temporary fix for the following scenarios:

  • Nova sends port update operation with nonempty device_id and device_owner (of value compute:nova). This request should be treated as CREATE from Alcor perspective.
  • Nova sends port update operation with empty device_id and device_owner. This request should be treated as DELETE.

The ultimate fix should be in Port Manager as the resource owner. We proposes this fix as a short-term solution to verify E2E success.

@cj-chung cj-chung requested review from cj-chung and xieus March 25, 2021 18:56
@xieus xieus added the bug Something isn't working label Mar 25, 2021
@xieus xieus changed the title hack fix for port update/create Temporary fix for port update/create Mar 25, 2021
@xieus
Copy link
Contributor

xieus commented Mar 25, 2021

Linked to tracking issue futurewei-cloud/alcor#103.

Copy link
Contributor

@xieus xieus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xieus xieus merged commit 817a652 into futurewei-cloud:master Mar 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants