This repository was archived by the owner on Mar 31, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 29
Enhance openflow communication performance #261
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
lfu-ps
commented
Aug 27, 2021
- "include/libfluid-" and "src/libfluid-" are copied from https://github.com/OpenNetworkingFoundation/libfluid_base and msg, they are third party open source libraries so you can skip reviewing, btw it is Apache 2.0 license (https://github.com/OpenNetworkingFoundation/libfluid_base/blob/master/LICENSE)
- please focus on how we leverage the libfluid fundamental, meaning the derived classes from it
- switch to openvswitch release version dependencies (https://www.openvswitch.org/download/) instead of the git src code version
- migrate ovs control functions to be compatible with the ovs release headers and lib
- style enforcement can be added on later, not fully completed on every header and src file
Pull latest master branch changes
…to deleted after added via ovs control vconn
…etter performance
Contributor
Author
|
ACA Crashes when Processing a Large Number of GoalStates at (Almost) the Same Time |
cj-chung
reviewed
Sep 7, 2021
cj-chung
reviewed
Sep 7, 2021
cj-chung
reviewed
Sep 7, 2021
pkommoju
reviewed
Sep 9, 2021
pkommoju
reviewed
Sep 9, 2021
cj-chung
approved these changes
Sep 9, 2021
Contributor
cj-chung
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
xieus
reviewed
Sep 10, 2021
Contributor
xieus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor comments.
xieus
reviewed
Sep 10, 2021
xieus
approved these changes
Sep 10, 2021
Contributor
xieus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @lfu-ps. This PR optimizes the comm layer significantly.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.