Skip to content
This repository was archived by the owner on Mar 31, 2023. It is now read-only.

Conversation

@lfu-ps
Copy link
Contributor

@lfu-ps lfu-ps commented Aug 27, 2021

  1. "include/libfluid-" and "src/libfluid-" are copied from https://github.com/OpenNetworkingFoundation/libfluid_base and msg, they are third party open source libraries so you can skip reviewing, btw it is Apache 2.0 license (https://github.com/OpenNetworkingFoundation/libfluid_base/blob/master/LICENSE)
  2. please focus on how we leverage the libfluid fundamental, meaning the derived classes from it
  3. switch to openvswitch release version dependencies (https://www.openvswitch.org/download/) instead of the git src code version
  4. migrate ovs control functions to be compatible with the ovs release headers and lib
  5. style enforcement can be added on later, not fully completed on every header and src file

@lfu-ps lfu-ps requested review from cj-chung and zzxgzgz August 27, 2021 03:46
@xieus xieus added enhancement New feature or request Feature labels Aug 30, 2021
@lfu-ps
Copy link
Contributor Author

lfu-ps commented Sep 3, 2021

ACA Crashes when Processing a Large Number of GoalStates at (Almost) the Same Time
Due to the new mechanism, the issue above is fixed with the refactoring. Tested with 1000 ports successfully.

Copy link
Contributor

@cj-chung cj-chung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@xieus xieus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor comments.

Copy link
Contributor

@xieus xieus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @lfu-ps. This PR optimizes the comm layer significantly.

@xieus xieus merged commit 8d78f13 into futurewei-cloud:master Sep 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request Feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ACA Crashes when Processing a Large Number of GoalStates at (Almost) the Same Time.

4 participants