This repository was archived by the owner on Mar 31, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 34
VPC Manager service module #134
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace Redis with Apache Ignite for in memory cache and db (#129)
xieus
reviewed
Mar 26, 2020
Contributor
xieus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good start. Let us remove all irrelevant files/sub-directories, move common files/sub-directories to a common directory, and keep the vpcmanager directory simple.
vpcmanager/src/main/java/com/futurewei/vpcmanager/config/OneBoxConfig.java
Outdated
Show resolved
Hide resolved
vpcmanager/src/main/java/com/futurewei/vpcmanager/dao/ICachePublisher.java
Show resolved
Hide resolved
vpcmanager/src/main/java/com/futurewei/vpcmanager/entity/HostInfo.java
Outdated
Show resolved
Hide resolved
vpcmanager/src/main/java/com/futurewei/vpcmanager/entity/NodeManager.java
Outdated
Show resolved
Hide resolved
This was
linked to
issues
Mar 27, 2020
xieus
approved these changes
Mar 27, 2020
Contributor
xieus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Approve!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Launch vpc manager service and create common library (lib):