This repository was archived by the owner on Mar 31, 2023. It is now read-only.
[Micro service] Consolidate web-related entities under AlcorWeb, add validation to VPC/Sunet Manager #195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace Redis with Apache Ignite for in memory cache and db (futurewei-cloud#129)
xieus
reviewed
May 21, 2020
Contributor
xieus
left a comment
xieus
left a comment
There was a problem hiding this comment.
Some initial feedback. Will keep looking.
services/port_manager/src/main/java/com/futurewei/alcor/portmanager/proxy/IpManagerProxy.java
Show resolved
Hide resolved
|
|
||
| import com.futurewei.alcor.web.entity.ip.IpAddrRequest; | ||
| import com.futurewei.alcor.web.restclient.IpManagerRestClient; | ||
| import com.futurewei.alcor.portmanager.restclient.IpManagerRestClient; |
Contributor
There was a problem hiding this comment.
oh why do we want to move rest clients from AlcroWeb back to Port Manager?
Contributor
Author
There was a problem hiding this comment.
Piaoping make the change I think ~
services/port_manager/src/main/java/com/futurewei/alcor/portmanager/util/SpringContextUtil.java
Show resolved
Hide resolved
| #apache.kafka.address=172.17.0.1:9092 | ||
| #server.port=9000 | ||
| #Ignite configuration | ||
| #ignite.host=192.168.137.1 |
Contributor
There was a problem hiding this comment.
Switching back and forward on different host ip is kind of headache. Let us create a new set of application.properties to be more developer friendly :-) when you get a chance.
services/route_manager/src/main/resources/application.properties
Outdated
Show resolved
Hide resolved
services/route_manager/src/main/resources/application.properties
Outdated
Show resolved
Hide resolved
xieus
suggested changes
May 21, 2020
Contributor
xieus
left a comment
xieus
left a comment
There was a problem hiding this comment.
A few more minor comments. I think this PR is good shape. Let us address the comments and merge it soon.
services/subnet_manager/src/main/java/com/futurewei/alcor/subnet/dao/SubnetRepository.java
Outdated
Show resolved
Hide resolved
| return true; | ||
| } | ||
|
|
||
| public static String localToUTC(String localTime, String format) { |
Contributor
There was a problem hiding this comment.
I was wondering if we could get a UTC time directly, instead of time zone conversion.
services/subnet_manager/src/main/resources/application.properties
Outdated
Show resolved
Hide resolved
...es/vpc_manager/src/main/java/com/futurewei/alcor/vpcmanager/utils/SegmentManagementUtil.java
Outdated
Show resolved
Hide resolved
services/vpc_manager/src/main/java/com/futurewei/alcor/vpcmanager/utils/VpcManagementUtil.java
Outdated
Show resolved
Hide resolved
This was
linked to
issues
May 21, 2020
xieus
changed the title
xieus
changed the title
…API is now completed
xieus
reviewed
May 22, 2020
web/src/main/java/com/futurewei/alcor/web/entity/subnet/SubnetEntity.java
Show resolved
Hide resolved
services/port_manager/src/main/java/com/futurewei/alcor/portmanager/proxy/IpManagerProxy.java
Show resolved
Hide resolved
# Conflicts: # services/mac_manager/pom.xml # services/mac_manager/src/main/java/com/futurewei/alcor/macmanager/controller/MacController.java # services/mac_manager/src/main/java/com/futurewei/alcor/macmanager/dao/MacPoolRepository.java # services/mac_manager/src/main/java/com/futurewei/alcor/macmanager/dao/MacRangeRepository.java # services/mac_manager/src/main/java/com/futurewei/alcor/macmanager/service/MacService.java # services/mac_manager/src/main/java/com/futurewei/alcor/macmanager/service/implement/MacServiceImpl.java # services/mac_manager/src/main/java/com/futurewei/alcor/macmanager/utils/RestPreconditionsUtil.java # services/mac_manager/src/main/resources/application.properties # services/mac_manager/src/test/java/com/futurewei/alcor/macmanager/controller/MacControllerTest.java # services/node_manager/src/main/resources/application.properties # web/src/main/java/com/futurewei/alcor/web/entity/mac/MacPool.java
# Conflicts: # services/mac_manager/src/main/resources/application.properties
xieus
reviewed
May 22, 2020
xieus
approved these changes
May 22, 2020
Contributor
xieus
left a comment
xieus
left a comment
There was a problem hiding this comment.
LGTM. Thanks for consolidating all the entities into one place, which take a lot of efforts but save us time when comes to integration :-)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes the following changes: