This repository was archived by the owner on Mar 31, 2023. It is now read-only.
Standardize service pom file and remove unused dependencies #198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
May 14, 2020 13:46
Contributor
|
LGTM |
kimeunju108
approved these changes
May 15, 2020
xieus
commented
May 15, 2020
| <groupId>org.springframework.boot</groupId> | ||
| <artifactId>spring-boot-starter-test</artifactId> | ||
| <scope>test</scope> | ||
| <exclusions> |
Contributor
Author
There was a problem hiding this comment.
@kimeunju108 Could you review this part to see which lib is needed. Currently the mac_manager pom change caused UT failure: https://jenkins.alkaidcloud.io/job/alcor-controller-pr-test/372/console
Contributor
Author
There was a problem hiding this comment.
If we add org.junit.vintage back, MacManager basically won't run any UTs.
Contributor
Author
There was a problem hiding this comment.
@kimeunju108, as this PR include other important payload, I will temporarily disable UTs for mac manager and go ahead to merge the PR.
Created an issue for tracking: #199
Please fix the UTs with priority. A service can't sustain for long without active UT running.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes the following changes:
Standardize project metadata (including groundID, artifactId, name, version) in pom files of various services, lib, web and schema.
Remove unused dependencies and plugin in pom files
Update dockerfiles of various services.