This repository was archived by the owner on Mar 31, 2023. It is now read-only.
Rename Port/Route Web Classes, and Update Kubernetes yaml #220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xieus
changed the title
xieus
approved these changes
May 28, 2020
Contributor
xieus
left a comment
xieus
left a comment
There was a problem hiding this comment.
Thanks @kevin-zhonghao. Approved with a few minor comments.
| path: application.properties | ||
| containers: | ||
| - image: zhonghaolyu/repo:macKube2 | ||
| - image: zhonghaolyu/repo:macKube1 |
Contributor
There was a problem hiding this comment.
Is it possible to use a local image link? if so, this could speed up the testing.
...es/port_manager/src/main/java/com/futurewei/alcor/portmanager/controller/PortController.java
Show resolved
Hide resolved
services/route_manager/src/main/java/com/futurewei/alcor/route/controller/RouteController.java
Outdated
Show resolved
Hide resolved
...e_manager/src/main/java/com/futurewei/alcor/route/service/Impl/RouteDatabaseServiceImpl.java
Outdated
Show resolved
Hide resolved
...ices/route_manager/src/main/java/com/futurewei/alcor/route/service/RouteDatabaseService.java
Outdated
Show resolved
Hide resolved
xieus
reviewed
May 28, 2020
services/private_ip_manager/src/main/resources/application.properties
Outdated
Show resolved
Hide resolved
xieus
reviewed
May 29, 2020
services/route_manager/src/main/java/com/futurewei/alcor/route/controller/RouteController.java
Outdated
Show resolved
Hide resolved
xieus
suggested changes
May 29, 2020
services/route_manager/src/main/java/com/futurewei/alcor/route/controller/RouteController.java
Show resolved
Hide resolved
...e_manager/src/main/java/com/futurewei/alcor/route/service/Impl/RouteDatabaseServiceImpl.java
Outdated
Show resolved
Hide resolved
...ices/route_manager/src/main/java/com/futurewei/alcor/route/service/RouteDatabaseService.java
Outdated
Show resolved
Hide resolved
services/route_manager/src/test/java/com/futurewei/alcor/route/RouteEntityControllerTests.java
Outdated
Show resolved
Hide resolved
| ** Estimated size of a middle-sized region is 500,000 node with 100 ports per node with consideration of multi-port container and VMs. | ||
| Thus, the estimated total number of ports is ~50 millions. | ||
| ** The estimated number of port-related resources (e.g. security groups, ACL, routes, DNS records and subnets) is of the same magnitude. | ||
| ** The estimated number of port-related resources (e.g. security groups, ACL, routeEntities, DNS records and subnets) is of the same magnitude. |
Contributor
There was a problem hiding this comment.
I think we need to revert the changes in *.adoc, *.puml, *.proto and application.properties.
Global replacement is dangerous :-)
Contributor
Author
There was a problem hiding this comment.
It's my bad ~ I will fix them
Contributor
Author
There was a problem hiding this comment.
Yeah you are right ! it's my fault
Contributor
There was a problem hiding this comment.
It is okay. It happened. Don't worry about it.
Waiting for the latest CI results to merge the PR.
xieus
changed the title
xieus
approved these changes
May 29, 2020
xieus
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes the following change: