This repository was archived by the owner on Mar 31, 2023. It is now read-only.
[Subnet Manager] Fix Ip Fallback Issue #300
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Docs/design
# Conflicts: # README.md # docs/modules/ROOT/pages/comm_protocol/fast_path.adoc # docs/modules/ROOT/pages/comm_protocol/rescue_path.adoc # docs/modules/ROOT/pages/controller.adoc # docs/modules/ROOT/pages/db_services/data_store.adoc # docs/modules/ROOT/pages/deploy_related/deployment.adoc # docs/modules/ROOT/pages/deploy_related/integration_nova.adoc # docs/modules/ROOT/pages/high_level/system_flow.adoc # docs/modules/ROOT/pages/mgmt_services/private_ip_manager.adoc # docs/modules/ROOT/pages/mgmt_services/security_group_manager.adoc # docs/modules/ROOT/pages/mgmt_services/virtual_mac_manager.adoc # docs/modules/ROOT/pages/mgmt_services/vpc_manager.adoc # docs/modules/ROOT/pages/sys_monitoring/monitoring.adoc
xieus
approved these changes
Jul 17, 2020
Contributor
xieus
left a comment
xieus
left a comment
There was a problem hiding this comment.
Thanks for this quick fix. LGTM.
services/route_manager/src/main/java/com/futurewei/alcor/route/controller/RouteController.java
Outdated
Show resolved
Hide resolved
xieus
changed the title
xieus
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes a fix to a subnet manager fallback bug.
Bug Description
The IpFallback method in Subnet Mgr used a legacy API of Private IP Manager for IP release. This caused a IP release failure in the case of Subnet creation failure, further leading to IP leaking in the subnet.