This repository was archived by the owner on Mar 31, 2023. It is now read-only.
[Microservice API] VPC Mgr and Subnet Mgr Issue Fix #307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Docs/design
# Conflicts: # README.md # docs/modules/ROOT/pages/comm_protocol/fast_path.adoc # docs/modules/ROOT/pages/comm_protocol/rescue_path.adoc # docs/modules/ROOT/pages/controller.adoc # docs/modules/ROOT/pages/db_services/data_store.adoc # docs/modules/ROOT/pages/deploy_related/deployment.adoc # docs/modules/ROOT/pages/deploy_related/integration_nova.adoc # docs/modules/ROOT/pages/high_level/system_flow.adoc # docs/modules/ROOT/pages/mgmt_services/private_ip_manager.adoc # docs/modules/ROOT/pages/mgmt_services/security_group_manager.adoc # docs/modules/ROOT/pages/mgmt_services/virtual_mac_manager.adoc # docs/modules/ROOT/pages/mgmt_services/vpc_manager.adoc # docs/modules/ROOT/pages/sys_monitoring/monitoring.adoc
xieus
suggested changes
Jul 21, 2020
Contributor
xieus
left a comment
xieus
left a comment
There was a problem hiding this comment.
This is very timely fix. Thank you @kevin-zhonghao.
I left a few comments. Please take a look.
| return null; | ||
| } | ||
|
|
||
| String[] highIps = highIp.split("\\."); |
Contributor
There was a problem hiding this comment.
Should we add the logic here?
cidrToFirstIpAndLastIp is used somewhere else that actually asks the first and last Ip, right? If so, then this new logic is going to break codes in those places.
I think we should have a new method that handles the cut explicitly.
Contributor
Author
There was a problem hiding this comment.
This method is used for creating Ip Address Range, and Ip Address Range may also need this fix, right? let us talk about this.
...net_manager/src/main/java/com/futurewei/alcor/subnet/service/implement/SubnetServiceImp.java
Outdated
Show resolved
Hide resolved
services/subnet_manager/src/test/java/com/futurewei/alcor/subnet/SubnetControllerTests.java
Show resolved
Hide resolved
...ices/vpc_manager/src/main/java/com/futurewei/alcor/vpcmanager/config/DefaultValueConfig.java
Outdated
Show resolved
Hide resolved
services/vpc_manager/src/main/java/com/futurewei/alcor/vpcmanager/controller/VpcController.java
Outdated
Show resolved
Hide resolved
...net_manager/src/main/java/com/futurewei/alcor/subnet/service/implement/SubnetServiceImp.java
Outdated
Show resolved
Hide resolved
...es/vpc_manager/src/main/java/com/futurewei/alcor/vpcmanager/service/Impl/VpcServiceImpl.java
Outdated
Show resolved
Hide resolved
...es/vpc_manager/src/main/java/com/futurewei/alcor/vpcmanager/service/Impl/VpcServiceImpl.java
Show resolved
Hide resolved
| response.setStatus(NetworkStatusEnum.ACTIVE.getNetworkStatus()); | ||
| } | ||
|
|
||
| // mtu |
Contributor
There was a problem hiding this comment.
Add //TDDO in the code to remind ourselves and community that the current logic will be updated and the plan
xieus
approved these changes
Jul 22, 2020
Contributor
xieus
left a comment
xieus
left a comment
There was a problem hiding this comment.
LGTM. Signed off with some minor comments.
services/subnet_manager/src/main/java/com/futurewei/alcor/subnet/config/ConstantsConfig.java
Outdated
Show resolved
Hide resolved
services/subnet_manager/src/test/java/com/futurewei/alcor/subnet/SubnetControllerTests.java
Show resolved
Hide resolved
...ices/subnet_manager/src/main/java/com/futurewei/alcor/subnet/utils/SubnetManagementUtil.java
Outdated
Show resolved
Hide resolved
...ices/subnet_manager/src/main/java/com/futurewei/alcor/subnet/utils/SubnetManagementUtil.java
Show resolved
Hide resolved
...ices/subnet_manager/src/main/java/com/futurewei/alcor/subnet/utils/SubnetManagementUtil.java
Show resolved
Hide resolved
...ices/subnet_manager/src/main/java/com/futurewei/alcor/subnet/utils/SubnetManagementUtil.java
Show resolved
Hide resolved
...ces/subnet_manager/src/main/java/com/futurewei/alcor/subnet/controller/SubnetController.java
Outdated
Show resolved
Hide resolved
xieus
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes four identified issues in VPC mgr and Subnet Mgr: