Alcor DVR Host Design and Protobuf Schema Change #339

er1cthe0ne · 2020-08-02T00:04:46Z

This PR includes:

Alcor DVR compute host design:

added router_design.adoc
workflow on router programming
E2E packet flow for Alcor DVR

Protobuf schema change:

added new states (router/neighbor)
added request id field for all states (port/subnet/vpc/dhcp/router/neighbor/securitygroup)
remove legacy contents

…into design/routing

moving from er1cthe0ne branch design/routing to er1cthe0ne master

xieus

Some early feedback to the proto change.

xieus · 2020-08-02T10:14:20Z

schema/proto3/common.proto

    PORT = 2;
-    SECURITYGROUP = 3;
-    DHCP = 4;
+    NEIGHBOR = 3;


Resource type is a type for customer-defined resources. Could you elaborate why neighbor is a type?

GoalStateOperationStatus includes ResourceType for GoalStateOperationReply. Since we introduced NeighborState in the schema, we need to add NEIGHBOR as ResourceType for our GoalStateOperationReply.

schema/proto3/dhcp.proto

schema/proto3/goalstate.proto

.gitignore

xieus · 2020-08-02T10:27:21Z

schema/proto3/subnet.proto

-    int64 tunnel_id = 8;
+    string request_id = 3;
+    string id = 4;
+    NetworkType network_type = 5;


Should we move network_type from port directly to network, instead of subnet? Do you plan to support two subnets in the same network with different values of network_type?

putting it in subnet level will allow us to support:

two subnets in the same network with different network_type

each network with n subnet will support one network_type only

@cj-chung can you help to find out what openstack neutron supports?

Note that we have the notion to look up subnet info, but we don't have the notion to look up vpc info (yet).

Neutron by default supports one network, one network type, and one segmentation id.

Ref: https://docs.openstack.org/api-ref/network/v2/?expanded=create-network-detail#create-network

Regarding two subnets with different network_type, DP will be pretty challenging.

Also, it supports one network with multiple segments, each with different network type and segmentation id.

"network": { "segments": [ { "provider:segmentation_id": 2, "provider:physical_network": "public", "provider:network_type": "vlan" }, { "provider:physical_network": "default", "provider:network_type": "flat" } ], "name": "net1", "admin_state_up": true, "qos_policy_id": "6a8454ade84346f59e8d40665f878b2e" } }

schema/proto3/neighbor.proto

xieus

LGTM. Signed off and merged to unblock the ACA PR futurewei-cloud/alcor-control-agent#119.

haboy52581

add comments about neighbor and dhcp

haboy52581 · 2020-08-05T05:04:29Z

schema/proto3/subnet.proto

+    // TODO: change to uint32 but that would require change in DPM
+    uint64 tunnel_id = 10;

    message Gateway {


I did not find Gateway definition in subnet proto

Also I have updated DPM's input about subnet Internal Entity part here, let me know if you have any questions:
https://github.com/haboy52581/alcor/blob/master/docs/modules/ROOT/pages/infra_services/data_plane_manager.adoc#api-specification

haboy52581 · 2020-08-05T23:30:45Z

schema/proto3/neighbor.proto

+        limitations under the License.
+*/
+
+syntax = "proto3";


should we put the neighbor to port as one field which is more naturally?

haboy52581 · 2020-08-05T23:37:35Z

schema/proto3/dhcp.proto

-    string ipv4_address = 4;
-    string ipv6_address = 5;
-    string port_host_name = 6; // for local DNS response
+    string request_id = 3;


do we need one called Id?

haboy52581 · 2020-08-05T23:38:22Z

schema/proto3/common.proto

-    FINALIZE = 9;              // For Mizar only
-    CREATE_UPDATE_SWITCH = 10; // For Mizar only
-    CREATE_UPDATE_ROUTER = 11; // For Mizar only
+    NEIGHBOR_CREATE_UPDATE = 5; // To be removed after using NeighborState


if we put neighbor into port as field, then we do NOT need NEIGHBORXXX type and logic to handle that

er1cthe0ne and others added 30 commits June 2, 2020 15:33

added skeleton routing design

6068e72

update per team discussions

680ee35

added packek flow info without DVR

25637f4

added DVR packet flows

9b842f7

updated DVR case 1 with openflow

a01f85d

added more text on requirements, DVR details

30f2de0

update based on feedback

7c3c538

added virtual router session

53f52c1

add figures

b0710ae

Merge branch 'design/routing' of https://github.com/er1cthe0ne/alcor …

f3682aa

…into design/routing

commit

6f0a0d1

added cross subnet DVR flow

2e0384f

change example-configuration.jpg

ecae2d5

Merge branch 'design/routing' of https://github.com/er1cthe0ne/alcor …

d9a8343

…into design/routing

modify example-configuration

b8cb2a9

updated cross subnet DVR flow

f7665f3

modify example configuration figure

60d4517

add Alcor DVR design text

8107089

Merge branch 'design/routing' of https://github.com/er1cthe0ne/alcor …

bfb6b60

…into design/routing

modify example architecture

defbdb5

added prototype openflow rules

58d9b32

added the generated cross subnet DVR flow

7471494

clean up OVS image

7a9e894

added MAC_HOST1_DVR info

9446971

update schema to support L3 routing

e1f5fb6

remove the breaking change for tunnel_id

99ab18a

added router flow

6019493

fix neighbor.proto build error

ee228a7

update schema and add router_workflow.png

3a41c6b

update based on PR feedback

a1dbb82

er1cthe0ne added 17 commits July 10, 2020 22:23

added MAC_HOST1_DVR info

1cfdd3d

update schema to support L3 routing

fb72874

remove the breaking change for tunnel_id

10eca45

added router flow

a352267

fix neighbor.proto build error

0fee74f

update schema and add router_workflow.png

eee8abe

update based on PR feedback

790606e

revert the breaking change to DPM on port config

3dd7068

added comment

2e209ec

Merge branch 'design/routing' of https://github.com/er1cthe0ne/alcor …

65f6810

…into design/routing

Merge pull request #1 from er1cthe0ne/design/routing

661b70c

moving from er1cthe0ne branch design/routing to er1cthe0ne master

adding new NEIGHBOR and PORT resource type

b538cd7

host_DVR_mac_address -> host_dvr_mac_address

a053168

added neighbor_host_dvr_mac to neighbor.proto

8a2613f

simplying the schema

c0069f1

added request id field

80783b0

Merge branch 'master' of https://github.com/futurewei-cloud/alcor

d91286f

er1cthe0ne added documentation Improvements or additions to documentation contract new or modified service interfaces labels Aug 2, 2020

er1cthe0ne requested review from cj-chung, haboy52581, kevin-zhonghao and xieus August 2, 2020 00:04

er1cthe0ne self-assigned this Aug 2, 2020

xieus reviewed Aug 2, 2020

View reviewed changes

move neighbor_host_dvr_mac up per feedback

ce29a09

xieus approved these changes Aug 5, 2020

View reviewed changes

xieus changed the title ~~Alcor DVR host design and protobuf schema change~~ Alcor DVR Host Design and Protobuf Schema Change Aug 5, 2020

xieus merged commit d186908 into futurewei-cloud:master Aug 5, 2020

haboy52581 reviewed Aug 5, 2020

View reviewed changes

Alcor DVR Host Design and Protobuf Schema Change #339

Alcor DVR Host Design and Protobuf Schema Change #339

Uh oh!

Conversation

er1cthe0ne commented Aug 2, 2020

Uh oh!

xieus left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

xieus left a comment

Choose a reason for hiding this comment

Uh oh!

haboy52581 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants