This repository was archived by the owner on Mar 31, 2023. It is now read-only.
[Microservice] Bug fixes for VPC Mgr and Subnet Mgr #341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # README.md # docs/modules/ROOT/pages/comm_protocol/fast_path.adoc # docs/modules/ROOT/pages/comm_protocol/rescue_path.adoc # docs/modules/ROOT/pages/controller.adoc # docs/modules/ROOT/pages/db_services/data_store.adoc # docs/modules/ROOT/pages/deploy_related/deployment.adoc # docs/modules/ROOT/pages/deploy_related/integration_nova.adoc # docs/modules/ROOT/pages/high_level/system_flow.adoc # docs/modules/ROOT/pages/mgmt_services/private_ip_manager.adoc # docs/modules/ROOT/pages/mgmt_services/security_group_manager.adoc # docs/modules/ROOT/pages/mgmt_services/virtual_mac_manager.adoc # docs/modules/ROOT/pages/mgmt_services/vpc_manager.adoc # docs/modules/ROOT/pages/sys_monitoring/monitoring.adoc
xieus
approved these changes
Aug 4, 2020
Contributor
xieus
left a comment
xieus
left a comment
There was a problem hiding this comment.
Looks good as a short-term fix. Requires two follow-up items:
- Long-term fix to identify customer-specified NULL and no passed-in parameter
- Add UT coverage.
...ces/subnet_manager/src/main/java/com/futurewei/alcor/subnet/controller/SubnetController.java
Outdated
Show resolved
Hide resolved
...ces/subnet_manager/src/main/java/com/futurewei/alcor/subnet/controller/SubnetController.java
Show resolved
Hide resolved
xieus
changed the title
xieus
approved these changes
Aug 5, 2020
| } | ||
|
|
||
| /** | ||
| * delete subnet id in a network |
|
|
||
| this.vpcDatabaseService.addVpc(inVpcState); | ||
|
|
||
| inVpcState = this.vpcDatabaseService.getByVpcId(vpcid); |
Contributor
There was a problem hiding this comment.
inVpcState => updatedVPcState
xieus
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes fix to the following issues:
Expected Behavior of Subnet Gateway
Description of GW IP Bug
Current Subnet Mgr is unable to differentiate the above two cases therefore always treating the first case same as second case. The customer impact is that the GW IP is missing for Case I. This PR proposes a short-term fix to unblock E2E integration test before we have a solid solution.