This repository was archived by the owner on Mar 31, 2023. It is now read-only.
[VPC Mgr] Fix VPC Creation Performance Issue #357
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xieus
reviewed
Aug 17, 2020
...s/vpc_manager/src/main/java/com/futurewei/alcor/vpcmanager/controller/SegmentController.java
Outdated
Show resolved
Hide resolved
services/vpc_manager/src/main/java/com/futurewei/alcor/vpcmanager/controller/VpcController.java
Outdated
Show resolved
Hide resolved
...pc_manager/src/main/java/com/futurewei/alcor/vpcmanager/service/Impl/SegmentServiceImpl.java
Show resolved
Hide resolved
...pc_manager/src/main/java/com/futurewei/alcor/vpcmanager/service/Impl/SegmentServiceImpl.java
Outdated
Show resolved
Hide resolved
...pc_manager/src/main/java/com/futurewei/alcor/vpcmanager/service/Impl/SegmentServiceImpl.java
Outdated
Show resolved
Hide resolved
...pc_manager/src/main/java/com/futurewei/alcor/vpcmanager/service/Impl/SegmentServiceImpl.java
Outdated
Show resolved
Hide resolved
xieus
changed the title
Contributor
|
@kevin-zhonghao In this PR description, can you detail the issue and how you fix it? Some recommended format like the following, which was how I edited the previous PR so I would like you to practice it as well :-) Bug Description Proposed Solution |
xieus
suggested changes
Aug 18, 2020
Contributor
xieus
left a comment
xieus
left a comment
There was a problem hiding this comment.
Look pretty good. I left a few more minor comments. Please take a look.
.../vpc_manager/src/main/java/com/futurewei/alcor/vpcmanager/allocator/NetworkKeyAllocator.java
Outdated
Show resolved
Hide resolved
|
|
||
| key = networkGRERange.allocateKey(); | ||
| cache.put(networkGRERange.getId(), networkGRERange); | ||
| if (!key.equals(ConstantsConfig.keyNotEnoughReturnValue)) { |
Contributor
There was a problem hiding this comment.
Recommend to put this check into a util method which could be used for other extended validation, not only checking keyNotEnoughReturnValue.
Contributor
Author
There was a problem hiding this comment.
Yeah that's right ~ but we could make this change when we have other extended validation later, what do you think
...pc_manager/src/main/java/com/futurewei/alcor/vpcmanager/service/Impl/SegmentServiceImpl.java
Outdated
Show resolved
Hide resolved
...pc_manager/src/main/java/com/futurewei/alcor/vpcmanager/service/Impl/SegmentServiceImpl.java
Show resolved
Hide resolved
...pc_manager/src/main/java/com/futurewei/alcor/vpcmanager/service/Impl/SegmentServiceImpl.java
Outdated
Show resolved
Hide resolved
...pc_manager/src/main/java/com/futurewei/alcor/vpcmanager/service/Impl/SegmentServiceImpl.java
Outdated
Show resolved
Hide resolved
...pc_manager/src/main/java/com/futurewei/alcor/vpcmanager/service/Impl/SegmentServiceImpl.java
Show resolved
Hide resolved
services/vpc_manager/src/test/java/com/futurewei/alcor/vpcmanager/SegmentControllerTests.java
Show resolved
Hide resolved
Contributor
|
@kevin-zhonghao This PR has some conflicting files with your other PR #353 that just got merged to master. Should be a minor fix. Pls take a look. |
# Conflicts: # services/vpc_manager/src/main/java/com/futurewei/alcor/vpcmanager/controller/SegmentController.java # services/vpc_manager/src/test/java/com/futurewei/alcor/vpcmanager/SegmentControllerTests.java
xieus
approved these changes
Aug 20, 2020
Contributor
xieus
left a comment
xieus
left a comment
There was a problem hiding this comment.
LGTM. Thanks for continuing tuning the performance.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug Description
The creation of vpc will take a long time (avg about 0.8s), and the time will increase as the amount of data in the database increases.
Proposed Solution
We found that the process of creating vxlan took a lot of time, so I replaced repo.findAllItems() in addVxlanEntity() method with repo.findItem() and set up partition as the key of the map in cache.