This repository was archived by the owner on Mar 31, 2023. It is now read-only.
[Documentation] Route Manager Design doc #382
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xieus
reviewed
Sep 10, 2020
Contributor
xieus
left a comment
xieus
left a comment
There was a problem hiding this comment.
Look great in general. One comment is to continue on designing the Subnet Mgr path, and keep APIs up to update.
| == Overview | ||
|
|
||
| The Route Manager is an Alcor microservice which manages the route tables and route entries for all VPCs and Subnets. | ||
| It also provides router-related functionalities to compatible with OpenStack Neutron's router APIs. |
Contributor
There was a problem hiding this comment.
Minor: to be compatible with
| . Router resource managed by an owner, Neutron or VPC. | ||
| . Route table resource managed by an owner, VPC or Subnet. | ||
| . Route entry should include destination, nexthop, target, and priority. | ||
| . Warning message should be raised if same route entry with different priority has been inserted by users. |
Contributor
There was a problem hiding this comment.
One more requirement:
- Warning message should be raised when adding an invalid routing rule
| ** API Gateway | ||
| //*** xref:_api_gateway.adoc[API Gateway] | ||
| ** xref:mgmt_services/mgmt_services_overview.adoc[Resource Management Services] | ||
| *** xref:mgmt_services/vpc_manager.adoc[VPC Manager] |
Contributor
There was a problem hiding this comment.
We will need a new route_manager_l3_neighbors_update_5.PNG to remove the grammar check warning.
Contributor
Author
There was a problem hiding this comment.
The PNG is recaptured without grammar check warning.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This design document includes concept, data schemas, APIs, and detailed workflows design for the management of routers, routing tables and routing rules in Alcor for both Neutron and VPC scenarios.