Skip to content
This repository was archived by the owner on Mar 31, 2023. It is now read-only.

Conversation

@kevin-zhonghao
Copy link
Contributor

@kevin-zhonghao kevin-zhonghao commented Sep 21, 2020

Fix the following issues when testing Neutron Router:

  1. Changed web class Json name in list routers API: neutronRouters -> routers.
  2. Fix the issue that can not find project id when create a neutron router.
  3. Fix the issue that the router id passed in is inconsistent with the router id stored in the database when create a neutron router.

@xieus xieus added the bug Something isn't working label Sep 21, 2020
@xieus xieus added this to the Version 0.9.2020.09.30 milestone Sep 21, 2020
@codecov-commenter
Copy link

Codecov Report

Merging #385 into master will decrease coverage by 0.00%.
The diff coverage is 40.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #385      +/-   ##
============================================
- Coverage     34.24%   34.24%   -0.01%     
  Complexity      959      959              
============================================
  Files           413      413              
  Lines         10086    10089       +3     
  Branches       1228     1229       +1     
============================================
+ Hits           3454     3455       +1     
- Misses         6189     6190       +1     
- Partials        443      444       +1     
Impacted Files Coverage Δ Complexity Δ
.../futurewei/alcor/route/utils/RouteManagerUtil.java 62.22% <ø> (ø) 6.00 <0.00> (ø)
...r/route/service/Impl/NeutronRouterServiceImpl.java 59.71% <33.33%> (-0.44%) 25.00 <0.00> (ø)
...lcor/route/controller/NeutronRouterController.java 60.15% <50.00%> (+0.31%) 12.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e30926c...afd208d. Read the comment docs.

Copy link
Contributor

@xieus xieus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the prompt fix.

@xieus xieus merged commit d0f8229 into futurewei-cloud:master Sep 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants