This repository was archived by the owner on Mar 31, 2023. It is now read-only.
[Contract] Add routers_internal to NetworkConfiguration Entity #396
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add dhcp/router/gateway/l2/l3 neighbor to port creation
change subnet info according to discussion this morning 08/05
haboy52581
requested review from
cj-chung
and removed request for
chenpiaoping
xieus
requested review from
chenpiaoping and
xieus
and removed request for
cj-chung
xieus
reviewed
Oct 5, 2020
web/src/main/java/com/futurewei/alcor/web/entity/dataplane/NetworkConfiguration.java
Outdated
Show resolved
Hide resolved
web/src/main/java/com/futurewei/alcor/web/entity/dataplane/NetworkConfiguration.java
Show resolved
Hide resolved
xieus
suggested changes
Oct 6, 2020
| "ip_address": "192.168.2.5", | ||
| "subnet_id": "a87e0f87-a2d9-44ef-9194-9a62f178594f" | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
Replace "tab" with space throughout the document.
web/src/main/java/com/futurewei/alcor/web/entity/dataplane/NetworkConfiguration.java
Outdated
Show resolved
Hide resolved
Contributor
|
@haboy52581 PR description please. |
Codecov Report
@@ Coverage Diff @@
## master #396 +/- ##
=========================================
Coverage ? 36.82%
Complexity ? 1153
=========================================
Files ? 447
Lines ? 10703
Branches ? 1365
=========================================
Hits ? 3941
Misses ? 6229
Partials ? 533 Continue to review full report at Codecov.
|
haboy52581
changed the title
xieus
approved these changes
Oct 6, 2020
xieus
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is mainly about: