This repository was archived by the owner on Mar 31, 2023. It is now read-only.
[Data Plane Mgr] Input Validation Module #427
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #427 +/- ##
=========================================
Coverage 36.81% 36.82%
Complexity 1152 1152
=========================================
Files 447 447
Lines 10706 10706
Branches 1367 1367
=========================================
+ Hits 3941 3942 +1
+ Misses 6232 6231 -1
Partials 533 533
Continue to review full report at Codecov.
|
xieus
reviewed
Oct 16, 2020
Contributor
xieus
left a comment
xieus
left a comment
There was a problem hiding this comment.
@kevin-zhonghao Thanks for pushing more validation. This is a way to solid backend engineer 👍
.../src/main/java/com/futurewei/alcor/dataplane/exception/validation/OperationTypeNotValid.java
Outdated
Show resolved
Hide resolved
...ne_manager/src/main/java/com/futurewei/alcor/dataplane/service/ovs/DataPlaneServiceImpl.java
Outdated
Show resolved
Hide resolved
...anager/src/main/java/com/futurewei/alcor/dataplane/utils/DataPlaneManagerValidationUtil.java
Outdated
Show resolved
Hide resolved
...anager/src/main/java/com/futurewei/alcor/dataplane/utils/DataPlaneManagerValidationUtil.java
Outdated
Show resolved
Hide resolved
...anager/src/main/java/com/futurewei/alcor/dataplane/utils/DataPlaneManagerValidationUtil.java
Outdated
Show resolved
Hide resolved
...anager/src/main/java/com/futurewei/alcor/dataplane/utils/DataPlaneManagerValidationUtil.java
Outdated
Show resolved
Hide resolved
...anager/src/main/java/com/futurewei/alcor/dataplane/utils/DataPlaneManagerValidationUtil.java
Outdated
Show resolved
Hide resolved
...anager/src/main/java/com/futurewei/alcor/dataplane/utils/DataPlaneManagerValidationUtil.java
Outdated
Show resolved
Hide resolved
xieus
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support the validation for input payload from port manager