This repository was archived by the owner on Mar 31, 2023. It is now read-only.
[Documentation] Subnet Mgr Redesign with Routing Rule Update #429
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xieus
added
documentation
Codecov Report
@@ Coverage Diff @@
## master #429 +/- ##
============================================
- Coverage 36.74% 36.59% -0.16%
- Complexity 1150 1162 +12
============================================
Files 448 453 +5
Lines 10759 10869 +110
Branches 1373 1393 +20
============================================
+ Hits 3953 3977 +24
- Misses 6268 6350 +82
- Partials 538 542 +4 Continue to review full report at Codecov.
|
xieus
reviewed
Oct 29, 2020
| * Normal response codes: 201 | ||
| * Error response codes: 400, 404, 500, 503 | ||
|
|
||
| * Error response codes: 400, 401, 404, 404, 409, 500, 503 |
Contributor
There was a problem hiding this comment.
We may need 412 Precondition Failed as well.
xieus
changed the title
xieus
approved these changes
Dec 2, 2020
Contributor
xieus
left a comment
xieus
left a comment
There was a problem hiding this comment.
Discussed offline and the overall design is solid. Signed off.
In this doc, we will need to update RM's integration with GWM when the GWM design is in place.
xieus
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend Subnet Manager's functionality to prepare InternalRouterInfo for routing rule update and InternalHostPortMap for host-port mapping, and send down both information to Data Plane manager.