-
Notifications
You must be signed in to change notification settings - Fork 34
[Contract] Support Port Delete and Preliminary Support of Zeta GW #467
Conversation
Codecov Report
@@ Coverage Diff @@
## master #467 +/- ##
============================================
+ Coverage 36.53% 36.56% +0.03%
- Complexity 1157 1159 +2
============================================
Files 452 452
Lines 10859 10861 +2
Branches 1392 1393 +1
============================================
+ Hits 3967 3971 +4
+ Misses 6350 6349 -1
+ Partials 542 541 -1
Continue to review full report at Codecov.
|
|
@chenpiaoping This is the PR change we discussed in the open-source meeting today. |
ok |
| uint32 port_inband_operation = 1; | ||
| } | ||
|
|
||
| oneof extra_info { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oneof is the good choice that fits our requirement.
One reminder that it could potentially cause memory crash in C++ code if not used properly, for example, delete one field and then try to set the deleted field. So please watch out for the implementation detail especially on oneof parsing and handling.
xieus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The contract change provides support for port delete and adds preliminary Zeta support. The change includes: