Skip to content
This repository was archived by the owner on Mar 31, 2023. It is now read-only.

Conversation

@er1cthe0ne
Copy link
Contributor

The contract change provides support for port delete and adds preliminary Zeta support. The change includes:

  1. added auxiliarygateway.proto to support generic gateways
  2. made AuxGateway generic for all gateways and use "oneof" to store extra info on specific implementation (e.g. zeta).
  3. added device_id and device_owner in proto.proto to support port delete scenario
  4. added auxiliary_gateway at vpc.proto
  5. fix compiler error in DPM because vpc tunnel ID is changed to uint

@er1cthe0ne er1cthe0ne added feature feature development contract new or modified service interfaces labels Nov 6, 2020
@er1cthe0ne er1cthe0ne self-assigned this Nov 6, 2020
@codecov-io
Copy link

Codecov Report

Merging #467 (f89226d) into master (97a7c17) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #467      +/-   ##
============================================
+ Coverage     36.53%   36.56%   +0.03%     
- Complexity     1157     1159       +2     
============================================
  Files           452      452              
  Lines         10859    10861       +2     
  Branches       1392     1393       +1     
============================================
+ Hits           3967     3971       +4     
+ Misses         6350     6349       -1     
+ Partials        542      541       -1     
Impacted Files Coverage Δ Complexity Δ
...r/route/service/Impl/NeutronRouterServiceImpl.java 51.49% <0.00%> (+0.29%) 27.00% <0.00%> (+1.00%)
...com/futurewei/alcor/macmanager/utils/MacUtils.java 65.21% <0.00%> (+8.69%) 8.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97a7c17...f89226d. Read the comment docs.

@xieus xieus requested a review from chenpiaoping November 12, 2020 04:20
@xieus
Copy link
Contributor

xieus commented Nov 12, 2020

@chenpiaoping This is the PR change we discussed in the open-source meeting today.

@chenpiaoping
Copy link
Contributor

@chenpiaoping This is the PR change we discussed in the open-source meeting today.

ok

uint32 port_inband_operation = 1;
}

oneof extra_info {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oneof is the good choice that fits our requirement.

One reminder that it could potentially cause memory crash in C++ code if not used properly, for example, delete one field and then try to set the deleted field. So please watch out for the implementation detail especially on oneof parsing and handling.

Copy link
Contributor

@xieus xieus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xieus xieus changed the title [DPM<->ACA contract] support port delete and preliminary Zeta support [Contract] Support Port Delete and Preliminary Support of Zeta GW Nov 12, 2020
@xieus xieus merged commit 456d800 into futurewei-cloud:master Nov 12, 2020
@er1cthe0ne er1cthe0ne deleted the schema/update branch November 19, 2020 19:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

contract new or modified service interfaces feature feature development

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants