Skip to content
This repository was archived by the owner on Mar 31, 2023. It is now read-only.

[Dependency] Upgrade Ignite to 2.9.0 #503

Merged
xieus merged 1 commit into from
Dec 3, 2020
Merged

[Dependency] Upgrade Ignite to 2.9.0 #503

xieus merged 1 commit into from
Dec 3, 2020

Conversation

@songxiaoyan
Copy link
Contributor

@songxiaoyan songxiaoyan commented Dec 3, 2020

Update iginte to 2.9.0

songxiaoyan
songxiaoyan commented Dec 3, 2020
View reviewed changes
legacy/pom.xml
<groupId>org.apache.ignite</groupId>
<artifactId>ignite-core</artifactId>
<version>2.8.1</version>
<version>2.9.0</version>
Copy link
Contributor Author

@songxiaoyan songxiaoyan Dec 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test comment

Copy link
Contributor

@xieus xieus Dec 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it works :-)

@xieus xieus requested a review from chenpiaoping December 3, 2020 08:27
@xieus xieus added dependencies Pull requests that update a dependency file deployment and upgrade labels Dec 3, 2020
@xieus xieus added this to the Version 1.0.2020.11.30 milestone Dec 3, 2020
@xieus xieus linked an issue Dec 3, 2020 that may be closed by this pull request
[Component Upgrade] Upgrade to Ignite 2.9 for better support of cluster management, distributed tracing #476
Closed
@xieus
Copy link
Contributor

xieus commented Dec 3, 2020

@songxiaoyan Congratulations to your first PR. Short but timely.

@xieus
Copy link
Contributor

xieus commented Dec 3, 2020

You can find the CI failure on this page https://github.com/futurewei-cloud/alcor/pull/503/checks?check_run_id=1491312470. Alternatively, you can click "Details" link on the row of failed Java CI.

You should be able to reproduce the same error on your local machine (following the instructions on https://github.com/futurewei-cloud/alcor/pull/503/checks?check_run_id=1491312470). It is related to Security Group manager.

@xieus
Copy link
Contributor

xieus commented Dec 3, 2020

@chenpiaoping Please review Xiaoyan's PR as well. Thanks.

@songxiaoyan
Copy link
Contributor Author

songxiaoyan commented Dec 3, 2020

@chenpiaoping Please review Xiaoyan's PR as well. Thanks.

You can find the CI failure on this page https://github.com/futurewei-cloud/alcor/pull/503/checks?check_run_id=1491312470. Alternatively, you can click "Details" link on the row of failed Java CI.

You should be able to reproduce the same error on your local machine (following the instructions on https://github.com/futurewei-cloud/alcor/pull/503/checks?check_run_id=1491312470). It is related to Security Group manager.

@songxiaoyan songxiaoyan closed this Dec 3, 2020
@songxiaoyan
Copy link
Contributor Author

songxiaoyan commented Dec 3, 2020

You can find the CI failure on this page https://github.com/futurewei-cloud/alcor/pull/503/checks?check_run_id=1491312470. Alternatively, you can click "Details" link on the row of failed Java CI.

You should be able to reproduce the same error on your local machine (following the instructions on https://github.com/futurewei-cloud/alcor/pull/503/checks?check_run_id=1491312470). It is related to Security Group manager.

Okey,I'm looking at this mistake.But I passed the local test before.

@songxiaoyan songxiaoyan reopened this Dec 3, 2020
@codecov-io
Copy link

codecov-io commented Dec 3, 2020

Codecov Report

Merging #503 (1103fa3) into master (df4df67) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #503   +/-   ##
=========================================
  Coverage     35.64%   35.64%           
  Complexity     1161     1161           
=========================================
  Files           467      467           
  Lines         11311    11311           
  Branches       1456     1456           
=========================================
  Hits           4032     4032           
  Misses         6723     6723           
  Partials        556      556

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df4df67...1103fa3. Read the comment docs.

@xieus xieus changed the title Update iginte to 2.9.0 [Dependency] Upgrade Ignite to 2.9.0 Dec 3, 2020
@xieus xieus merged commit 053018d into futurewei-cloud:master Dec 3, 2020
@songxiaoyan songxiaoyan deleted the ignite-update branch December 15, 2020 02:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@xieus xieus xieus left review comments

@chenpiaoping chenpiaoping chenpiaoping approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@songxiaoyan songxiaoyan

Labels

dependencies Pull requests that update a dependency file deployment and upgrade

Projects

None yet

Milestone

Version 0.10.2020.11.30

Development

Successfully merging this pull request may close these issues.

[Component Upgrade] Upgrade to Ignite 2.9 for better support of cluster management, distributed tracing

4 participants

@songxiaoyan @xieus @codecov-io @chenpiaoping