Skip to content
This repository was archived by the owner on Mar 31, 2023. It is now read-only.

Conversation

@kevin-zhonghao
Copy link
Contributor

@kevin-zhonghao kevin-zhonghao commented Dec 4, 2020

Hotfix for subnet deletion and update:

  1. Add update gateway port in PM step in Add/Remove interface to router API.
  2. Fix web class display error in swagger ui.
  3. Fix subnet deletion and update issue.
  4. revert rbac configuration. https://github.com/futurewei-cloud/alcor/pull/502/files

@xieus xieus requested review from cj-chung and xieus December 4, 2020 20:59
@codecov-io
Copy link

codecov-io commented Dec 4, 2020

Codecov Report

Merging #507 (efa6e35) into master (977ac09) will decrease coverage by 0.00%.
The diff coverage is 23.52%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #507      +/-   ##
============================================
- Coverage     35.72%   35.72%   -0.01%     
  Complexity     1163     1163              
============================================
  Files           467      468       +1     
  Lines         11305    11318      +13     
  Branches       1453     1456       +3     
============================================
+ Hits           4039     4043       +4     
- Misses         6715     6723       +8     
- Partials        551      552       +1     
Impacted Files Coverage Δ Complexity Δ
...lcor/route/service/Impl/RouterToPMServiceImpl.java 6.66% <0.00%> (-1.03%) 1.00 <0.00> (ø)
...lcor/subnet/exception/CanNotUpdateGatewayPort.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...cor/subnet/service/implement/SubnetServiceImp.java 1.11% <ø> (ø) 1.00 <0.00> (ø)
...ewei/alcor/subnet/controller/SubnetController.java 57.30% <20.00%> (-0.97%) 16.00 <0.00> (ø)
...r/route/service/Impl/NeutronRouterServiceImpl.java 40.30% <100.00%> (+0.25%) 28.00 <0.00> (ø)
...alcor/elasticipmanager/dao/ElasticIpAllocator.java 63.81% <0.00%> (+0.27%) 48.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 977ac09...efa6e35. Read the comment docs.

Copy link
Contributor

@cj-chung cj-chung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@xieus please merge the code, so that we can verify it in our cluster.

@xieus xieus added the bug Something isn't working label Dec 8, 2020
@xieus xieus added this to the Version 1.0.2020.11.30 milestone Dec 8, 2020
Copy link
Contributor

@cj-chung cj-chung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xieus xieus changed the title [HotFix] Temporary solution for subnet deletion and update [Hotfix] Fix Subnet Deletion and Update Issues Dec 8, 2020
@xieus xieus linked an issue Dec 8, 2020 that may be closed by this pull request
@xieus xieus merged commit 28cfda5 into futurewei-cloud:master Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Subnet] Delete a subnet got 404 error from Route Manager

4 participants