This repository was archived by the owner on Mar 31, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 34
[Hotfix] Fix Subnet Deletion and Update Issues #507
Merged
xieus
merged 21 commits into
futurewei-cloud:master
from
kevin-zhonghao:fix/issue_495_update_new
Dec 8, 2020
Merged
[Hotfix] Fix Subnet Deletion and Update Issues #507
xieus
merged 21 commits into
futurewei-cloud:master
from
kevin-zhonghao:fix/issue_495_update_new
Dec 8, 2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #507 +/- ##
============================================
- Coverage 35.72% 35.72% -0.01%
Complexity 1163 1163
============================================
Files 467 468 +1
Lines 11305 11318 +13
Branches 1453 1456 +3
============================================
+ Hits 4039 4043 +4
- Misses 6715 6723 +8
- Partials 551 552 +1
Continue to review full report at Codecov.
|
cj-chung
approved these changes
Dec 4, 2020
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@xieus please merge the code, so that we can verify it in our cluster.
cj-chung
approved these changes
Dec 8, 2020
Contributor
cj-chung
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hotfix for subnet deletion and update: