This repository was archived by the owner on Mar 31, 2023. It is now read-only.
One port supports multiple neighbors && Fix the failure to update port #521
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenpiaoping
force-pushed
the
port-manager
branch
from
0f511c7 to
ce3c9b1
Compare
Contributor
Author
|
@xieus Sorry that the previous PR led to the failure to update the port. This PR will solve the problem. |
xieus
requested review from
cj-chung and
xieus
and removed request for
xieus
xieus
approved these changes
Dec 22, 2020
| private ICache<String, PortNeighbors> neighborCache; | ||
| private CacheFactory cacheFactory; | ||
|
|
||
| public NeighborRepository(CacheFactory cacheFactory) { |
Contributor
There was a problem hiding this comment.
@chenpiaoping When you get a chance, please update the PM design doc and list the repositories used in Port? It is time for us to sync the doc with the implementation as we are looking into perf optimization.
| subnetPortIdsCache.put(subnetId, subnetPortIds); | ||
| } | ||
|
|
||
| neighborRepository.createNeighbors(neighbors); |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.