Skip to content
This repository was archived by the owner on Mar 31, 2023. It is now read-only.

Conversation

@chenpiaoping
Copy link
Contributor

@chenpiaoping chenpiaoping commented Jan 4, 2021

Fix the port creation failure in DPM v2.0.

@chenpiaoping chenpiaoping requested a review from xieus January 4, 2021 03:42
@chenpiaoping chenpiaoping self-assigned this Jan 4, 2021
@chenpiaoping chenpiaoping linked an issue Jan 4, 2021 that may be closed by this pull request
@chenpiaoping chenpiaoping changed the title Fail to create a port Fix the problem of failed to create port Jan 4, 2021
@codecov-io
Copy link

codecov-io commented Jan 4, 2021

Codecov Report

Merging #530 (21f0a78) into master (9008390) will increase coverage by 0.07%.
The diff coverage is 76.19%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #530      +/-   ##
============================================
+ Coverage     32.74%   32.82%   +0.07%     
- Complexity     1108     1115       +7     
============================================
  Files           473      473              
  Lines         11751    11772      +21     
  Branches       1514     1521       +7     
============================================
+ Hits           3848     3864      +16     
- Misses         7368     7370       +2     
- Partials        535      538       +3     
Impacted Files Coverage Δ Complexity Δ
.../portmanager/processor/SecurityGroupProcessor.java 54.65% <68.75%> (+3.22%) 17.00 <0.00> (+4.00)
...lcor/portmanager/processor/DataPlaneProcessor.java 63.12% <100.00%> (+0.46%) 30.00 <0.00> (+1.00)
...rewei/alcor/portmanager/processor/PortContext.java 48.64% <100.00%> (+2.16%) 21.00 <2.00> (+2.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9008390...21f0a78. Read the comment docs.

@chenpiaoping
Copy link
Contributor Author

@xieus @kevin-zhonghao Please review this PR when you have time.

Copy link
Contributor

@xieus xieus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@xieus xieus changed the title Fix the problem of failed to create port [HotFix] Port Creation Fix in DPM v2.0 Jan 8, 2021
@xieus xieus merged commit 9b2b99f into futurewei-cloud:master Jan 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[PM - DPM] Fail to create a port

3 participants