Skip to content
This repository was archived by the owner on Mar 31, 2023. It is now read-only.

Conversation

@er1cthe0ne
Copy link
Contributor

We moved the gateway configuration as a top level resource recently. This is a followup change to put gateway state into the top level goal state message.

@er1cthe0ne er1cthe0ne added the contract new or modified service interfaces label Jan 22, 2021
@er1cthe0ne er1cthe0ne requested review from cj-chung and xieus January 22, 2021 22:28
@er1cthe0ne er1cthe0ne self-assigned this Jan 22, 2021
Copy link
Contributor

@cj-chung cj-chung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

TGW = 2; // Transit Gateway
IGW = 3; // Internet Gateway
NGW = 4; // NAT Gateway
ZETA = 0;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DEFAULT = 0;
...

@codecov-io
Copy link

Codecov Report

Merging #543 (8d23cae) into master (c9ccfd6) will increase coverage by 0.25%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #543      +/-   ##
============================================
+ Coverage     34.88%   35.13%   +0.25%     
- Complexity     1182     1226      +44     
============================================
  Files           473      491      +18     
  Lines         11799    12133     +334     
  Branches       1526     1545      +19     
============================================
+ Hits           4116     4263     +147     
- Misses         7115     7292     +177     
- Partials        568      578      +10     
Impacted Files Coverage Δ Complexity Δ
...ewei/alcor/subnet/controller/SubnetController.java 54.18% <0.00%> (ø) 13.00% <0.00%> (ø%)
...cor/subnet/service/implement/SubnetServiceImp.java 1.10% <0.00%> (ø) 1.00% <0.00%> (ø%)
...nager/service/implement/NetworkAclServiceImpl.java 87.73% <0.00%> (ø) 29.00% <0.00%> (ø%)
...i/alcor/gatewaymanager/service/GatewayService.java 58.06% <0.00%> (ø) 11.00% <0.00%> (?%)
...cor/gatewaymanager/utils/VerifyParameterUtils.java 30.76% <0.00%> (ø) 3.00% <0.00%> (?%)
...ei/alcor/gatewaymanager/dao/GatewayRepository.java 52.77% <0.00%> (ø) 6.00% <0.00%> (?%)
...r/gatewaymanager/controller/GatewayController.java 62.06% <0.00%> (ø) 5.00% <0.00%> (?%)
...cor/gatewaymanager/dao/GWAttachmentRepository.java 27.27% <0.00%> (ø) 3.00% <0.00%> (?%)
...i/alcor/gatewaymanager/entity/GatewaysWebJson.java 0.00% <0.00%> (ø) 0.00% <0.00%> (?%)
...manager/exception/AttachmentNotFoundException.java 0.00% <0.00%> (ø) 0.00% <0.00%> (?%)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9ccfd6...8d23cae. Read the comment docs.

Copy link
Contributor

@xieus xieus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xieus xieus changed the title [Schema] adding gateway state into goal state message [Schema] Adding Gateway State into GS Message Jan 23, 2021
@xieus xieus merged commit d1376a9 into futurewei-cloud:master Jan 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

contract new or modified service interfaces

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants