This repository was archived by the owner on Mar 31, 2023. It is now read-only.
[Port Mgr] Handle internal DPM result list #549
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
songxiaoyan
commented
Feb 27, 2021
songxiaoyan
commented
- Currently, only the gRPC interface invoking result is processed.
- If the puslar interface fails to be invoked,puslar will be repeatedly invoked until it is successfully invoked.
- On present, only the PM module processes the result.
# Conflicts: # services/port_manager/src/main/java/com/futurewei/alcor/portmanager/processor/FixedIpsProcessor.java # services/port_manager/src/main/java/com/futurewei/alcor/portmanager/request/RequestManager.java # services/private_ip_manager/src/main/java/com/futurewei/alcor/privateipmanager/controller/IpAddrController.java # services/private_ip_manager/src/main/java/com/futurewei/alcor/privateipmanager/repo/IpAddrRangeRepo.java # services/private_ip_manager/src/main/java/com/futurewei/alcor/privateipmanager/service/implement/IpAddrServiceImpl.java
# Conflicts: # services/port_manager/src/main/java/com/futurewei/alcor/portmanager/request/UpdatePortIpAddressRequest.java
Codecov Report
@@ Coverage Diff @@
## master #549 +/- ##
============================================
+ Coverage 34.34% 34.44% +0.09%
- Complexity 1229 1239 +10
============================================
Files 501 502 +1
Lines 12365 12407 +42
Branches 1558 1567 +9
============================================
+ Hits 4247 4273 +26
- Misses 7541 7556 +15
- Partials 577 578 +1
Continue to review full report at Codecov.
|
xieus
reviewed
Mar 1, 2021
Contributor
xieus
left a comment
xieus
left a comment
There was a problem hiding this comment.
@songxiaoyan looks good with one minor comment.
services/port_manager/src/main/java/com/futurewei/alcor/portmanager/entity/PortStatusEnum.java
Outdated
Show resolved
Hide resolved
xieus
changed the title
cj-chung
reviewed
Mar 3, 2021
Comment on lines
+48
to
51
| @PostMapping({"/network-configuration", "v4/network-configuration"}) | ||
| @DurationStatistics | ||
| public InternalDPMResultList updateNetworkConfiguration(@RequestBody NetworkConfiguration networkConfiguration) throws Exception { | ||
| checkNetworkConfiguration(networkConfiguration); |
Contributor
There was a problem hiding this comment.
@songxiaoyan and @xieus This change will break dpm. There are two PostMapping with the same url after you change line48 from Put to Post.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.