Skip to content
This repository was archived by the owner on Mar 31, 2023. It is now read-only.

Conversation

@VanderChen
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented May 12, 2021

Codecov Report

Merging #612 (1a219a5) into master (a78e1d4) will decrease coverage by 0.80%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #612      +/-   ##
============================================
- Coverage     32.77%   31.96%   -0.81%     
  Complexity     1248     1248              
============================================
  Files           522      525       +3     
  Lines         13111    13439     +328     
  Branches       1610     1657      +47     
============================================
- Hits           4297     4296       -1     
- Misses         8229     8558     +329     
  Partials        585      585              
Impacted Files Coverage Δ Complexity Δ
...alcor/elasticipmanager/dao/ElasticIpAllocator.java 63.53% <0.00%> (-0.28%) 48.00% <0.00%> (ø%)
...turewei/alcor/netwconfigmanager/util/DemoUtil.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
...ei/alcor/netwconfigmanager/constant/Constants.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
...i/alcor/netwconfigmanager/entity/ResourceMeta.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
...lcor/netwconfigmanager/cache/VpcResourceCache.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
...lcor/netwconfigmanager/entity/VpcResourceMeta.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
...or/netwconfigmanager/cache/ResourceStateCache.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
...twconfigmanager/util/NetworkConfigManagerUtil.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
...configmanager/NetworkConfigManagerApplication.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
...configmanager/cache/HostResourceMetadataCache.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a78e1d4...1a219a5. Read the comment docs.

@xieus xieus self-requested a review May 18, 2021 21:26
@xieus xieus added the feature feature development label May 18, 2021
@xieus xieus added this to the Version 0.17.2021.07.30 milestone May 18, 2021
message NodeSubscribeInfo {
SubscribeOperation subscribe_operation = 1;
string topic = 2;
string key = 3;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does the key differ from topic?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The key is for key-shared mode in Pulsar. It's similar to the concept of a secondary topic in the message queue (e.g. key in Apache Pulsar, tag in RocketMQ). At the same time, this value can be set to null when it is not needed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great to put the comment of "Allow to set NULL when a secondary topic is not needed" for the key field. @VanderChen

Copy link
Contributor

@xieus xieus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@VanderChen I have one last minor comment. Please take a look and if you can fix it in your other PR, that would be great.

@xieus xieus added the schema New or change of schema label May 25, 2021
@xieus xieus changed the title Add grpc channl to notify node subscribe MQ [Schema Change] Add gRPC channel to notify node subscribe MQ May 25, 2021
@xieus xieus merged commit ae70342 into futurewei-cloud:master May 25, 2021
@VanderChen VanderChen deleted the mq-grpc-vpc branch February 3, 2022 02:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

feature feature development schema New or change of schema

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants