Skip to content
This repository was archived by the owner on Mar 31, 2023. It is now read-only.

Conversation

@pkommoju
Copy link
Contributor

@pkommoju pkommoju commented May 29, 2021

This PR proposes the following fixes:

  • Fix ovs-docker port deletion command syntax error which made the rest of the test suspicious.
  • Fix the order of network element creation and operations for L3 scenario 4 test (ping test with -t 1 options)
  • Add some extra debug output for now.

pkommoju added 6 commits May 12, 2021 11:34
Add document about transactional semantics for Alcor Caches in general
and spefically about Ignite Caches.
the test suspicious.

Fix the odrder of network element creation and operations for L3
scenario 4 test (ping test with -t 1 options)

Add some extra debug output for now.
@pkommoju pkommoju requested a review from cj-chung May 29, 2021 02:02
@codecov-commenter
Copy link

Codecov Report

Merging #623 (d8cccd2) into master (35c879f) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #623      +/-   ##
============================================
- Coverage     31.91%   31.90%   -0.01%     
  Complexity     1247     1247              
============================================
  Files           525      525              
  Lines         13462    13462              
  Branches       1666     1666              
============================================
- Hits           4296     4295       -1     
- Misses         8579     8580       +1     
  Partials        587      587              
Impacted Files Coverage Δ
...alcor/elasticipmanager/dao/ElasticIpAllocator.java 63.53% <0.00%> (-0.28%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35c879f...d8cccd2. Read the comment docs.

Copy link
Contributor

@xieus xieus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @pkommoju

@xieus xieus added bug Something isn't working cicd CI/CD workflow labels May 29, 2021
@xieus xieus added this to the Version 0.17.2021.07.30 milestone May 29, 2021
@xieus xieus changed the title Ping test s4 order fix [CI/CD E2E] Improve ping test script May 29, 2021
@xieus xieus merged commit 620df1a into futurewei-cloud:master May 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug Something isn't working cicd CI/CD workflow

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants