Skip to content
This repository was archived by the owner on Mar 31, 2023. It is now read-only.

Conversation

@DavidLiu506
Copy link
Contributor

1 Send Arion gateway ip and mac to ACA.
2 Add consistent hash

DavidLiu506 and others added 30 commits June 29, 2021 12:07
@xieus xieus added the feature feature development label Jun 30, 2022
NeighborType neighbor_type = 1;
string subnet_id = 2;
string ip_address = 3;
string arion_group = 4;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DavidLiu506 Let us discuss this. Hopefully we could reuse Alcor basic data structure to support Arion.

TGW = 2; // Transit Gateway
IGW = 3; // Internet Gateway
NGW = 4; // NAT Gateway
ARION=5;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"ARION = 5"

Comment on lines +58 to +59
// port for in-band (same NIC channel) operation
uint32 port_inband_operation = 4;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a port id or?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the port number for the in-band operation. Say, port_inband_operation=1234, then when ACA receives this Gateway State, it creates a UDP server at this port(1234) to receive the OAM packet sent by an Arion Wing.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zzxgzgz thank you!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zzxgzgz based on the new design, the OAM packet is sent by a local OAM agent, not the Arion Wing, right?




service ArionMasterService {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the API provided by Arion Master? if so, we may put it in the Arion project and submodule from here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good suggestions. Thank you!

Copy link
Contributor

@xieus xieus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments, mostly minor.

Comment on lines +58 to +59
// port for in-band (same NIC channel) operation
uint32 port_inband_operation = 4;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zzxgzgz based on the new design, the OAM packet is sent by a local OAM agent, not the Arion Wing, right?

// arionWingCache store Arion wing meta data. key is Arion Wing hash code and value is Arion wing meta data.
private ICache<String, ArionWing> arionWingCache;

// arionWingGroupCache store Arion group meta data. key is Arion wing group name, value is Arion wing meta data.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the value here Arion group info? What is the difference from ArionWing which is the wing meta data.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Arion group cache store all arion group info.

Here is Arion Wing meta data:

private String group;
private String ip;
private String mac;
private int port;

There is a group member in Arion Wing meta data mean which group they belong to

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There might be several Arion Wing belong to one group

Copy link
Contributor

@xieus xieus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xieus xieus merged commit bfdbd34 into futurewei-cloud:master Jul 7, 2022
DavidLiu506 added a commit to DavidLiu506/alcor that referenced this pull request Aug 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

feature feature development

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants