Skip to content

fix: escape clip name in TableClipStrategy.DefaultXml #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fuzzzerd merged 1 commit into from
May 16, 2026
Merged

fix: escape clip name in TableClipStrategy.DefaultXml #212

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/SharpFM.Model/ClipTypes/TableClipStrategy.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
using System.Collections.Generic;
using SharpFM.Model.Parsing;
using SharpFM.Model.Schema;
using SharpFM.Model.Scripting;

namespace SharpFM.Model.ClipTypes;

Expand Down Expand Up @@ -63,6 +64,6 @@ public ClipParseResult Parse(string xml)

public string DefaultXml(string clipName) =>
_wrapsBaseTable
? $"<fmxmlsnippet type=\"FMObjectList\"><BaseTable name=\"{clipName}\"></BaseTable></fmxmlsnippet>"
? $"<fmxmlsnippet type=\"FMObjectList\"><BaseTable name=\"{XmlHelpers.XmlEscape(clipName)}\"></BaseTable></fmxmlsnippet>"
: "<fmxmlsnippet type=\"FMObjectList\"></fmxmlsnippet>";
}
15 changes: 15 additions & 0 deletions tests/SharpFM.Tests/ClipTypes/TableClipStrategyTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,4 +69,19 @@ public void DefaultXml_ProducesParseableSnippet()
var result = TableClipStrategy.Table.Parse(seed);
Assert.IsType<ParseSuccess>(result);
}

[Theory]
[InlineData("My \"favorite\" stuff")]
[InlineData("A & B")]
[InlineData("<Angle>")]
public void Table_DefaultXml_EscapesPunctuationInName(string clipName)
{
var seed = TableClipStrategy.Table.DefaultXml(clipName);

var result = TableClipStrategy.Table.Parse(seed);

var success = Assert.IsType<ParseSuccess>(result);
var model = Assert.IsType<TableClipModel>(success.Model);
Assert.Equal(clipName, model.Table.Name);
}
}
Loading