Skip to content

fix: remove alert(0) from production build#127

Merged
fx merged 2 commits intomainfrom
fix/126-remove-alert-zero
Jul 10, 2025
Merged

fix: remove alert(0) from production build#127
fx merged 2 commits intomainfrom
fix/126-remove-alert-zero

Conversation

@fx
Copy link
Copy Markdown
Owner

@fx fx commented Jul 10, 2025

Closes #126

Summary

  • Removed alert() call from test-store.tsx that was being included in production builds
  • Added unit tests to prevent alert() calls in production builds
  • Verified that production build no longer contains any alert() calls

Root Cause

The issue was caused by an alert() call in the test-store.tsx route that was being included in the production build. While the alert was showing "Configuration exported!" in the source code, it may have been transformed during minification or there may have been another source of alert(0) that has now been resolved.

Testing

  • Added comprehensive build checks test suite
  • Verified no alert() calls exist in production build
  • Verified no alert(0) specifically exists in production build
  • All tests pass

Test Evidence

=== VERIFICATION ===
1. Checking for any alert() calls in production build:
No alert() calls found ✓

2. Checking for alert(0) specifically:
No alert(0) found ✓

3. File size:
932K
✓ src/__tests__/build-checks.test.ts (4 tests  < /dev/null |  1 skipped) 11ms

Test Files  1 passed (1)
Tests  3 passed | 1 todo (4)

@fx fx merged commit 0f688bf into main Jul 10, 2025
2 checks passed
@fx fx deleted the fix/126-remove-alert-zero branch July 10, 2025 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Production build loads w/ a alert() that says 0

1 participant