Skip to content

Feat: whitelist system#10

Merged
andreutu merged 45 commits into
mainfrom
feat/whitelist-system
May 17, 2026
Merged

Feat: whitelist system#10
andreutu merged 45 commits into
mainfrom
feat/whitelist-system

Conversation

@Maximus7474

@Maximus7474 Maximus7474 commented May 11, 2026

Copy link
Copy Markdown
Collaborator

Description

This PR introduces a whitelisting system, including as features:

  • discord manager (wrapper connecting to discord's API)
  • varying whitelisting methods (identifier, discord role, admin only)
  • whitelist page to handle identifier based whitelisting
    • removing a whitelisted will remove the player if connected

Tests

  • Tested in development mode
  • Passes typecheck
  • Builds & runs on Windows
  • Builds & runs on Linux

Additional Notes

Future considerations can improve the system, this is to be considered as a base system / initial version.

@andreutu andreutu left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The whitelist works very well, however the whitelist page does not dynamically update (e.g. when removing an entry, I need to refresh the page before changes are shown).

Moreover, seems like there is a bug regarding the connected players list. There are 2 entries in the "Player List" each time I connect, but it does not seem like it's related to the changes this PR comes with.

@Maximus7474

Copy link
Copy Markdown
Collaborator Author

The whitelist works very well, however the whitelist page does not dynamically update (e.g. when removing an entry, I need to refresh the page before changes are shown).

Damn, forgot that one. I thought using the navigator would help refresh the data, I'll just externalise the fetch in a callbacked function and trigger that on successful add/remove.

Moreover, seems like there is a bug regarding the connected players list. There are 2 entries in the "Player List" each time I connect, but it does not seem like it's related to the changes this PR comes with.

I haven't seen that one yet, it shows up properly for myself.

@Maximus7474 Maximus7474 requested a review from andreutu May 16, 2026 21:36

@andreutu andreutu left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andreutu andreutu merged commit 9987f96 into main May 17, 2026
2 checks passed
@Maximus7474 Maximus7474 deleted the feat/whitelist-system branch May 17, 2026 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants