feat: settings page and enhancements#25
Conversation
Maximus7474
left a comment
Maximus7474
left a comment
There was a problem hiding this comment.
Looks good overall, a couple little adjustments on the contents.
Also noticed that there was no field for inputting discord bot token, are we keeping that as an env variable ?
I'm thinking it would be better this way and more secure, but on second thought I think it should be a good addition. Should I add it? |
|
Well, I think it would be best. Might develop the settings to adapt what can be accessed/changed so it's not just one permission. |
I think anything that is currently a env unless it touches ports etc. (that might break our shit) it should just be configureable on the webpanel for end users. Most people in fivem will NOT know how to edit a .env |
Highly doubt 90% of people will even be able to run fxManager, but yeah I'll add that. |
Well the entire community running dodgy game panels won't be able to, unless companies decide to implement it. |
|
Discord bot token is now configurable, should be good to merge. |
3 participants
Description
Implements a settings page that can be used to configure various aspects of fxManager. As of now, the amount of customizable options is limited, but its structure and modularity will allow for easy expansions as features are progressively added.
Related managers, routes and parts of the codebase have been refactored to account for using settings instead of hardcoded or environment values. Moreover, a redo of how settings are structured has been implemented which now separates settings by categories (scopes), and invalid values (scopes and keys) are now restricted.
Tests
Additional Notes
N/A