feat: groups & acepermissions#38
Merged
Merged
Conversation
- assignGroup clears stale personal permission bits (hidden privilege retention) - validate group before creating admin (orphaned account with lost password) - register group.* audit actions so the audit UI can filter them - delta-based ace resync: no stdin flood, no transient no-permission window - refresh aces when a staff member's license is first recorded on join - blank-name guard on group update, audit logs stored (not requested) perms - dedupe AdminGroupForm type, drop dead hideReset prop, single dialog state
The create route dropped the form's player selection, so a newly created admin was never linked to a player. Thread playerId through createUser (linked in the same insert for atomicity) and resync aces so the in-game principal is pushed immediately.
github-actions
Bot
added
area: core
area: webpanel
area: database
type: migration
…gleton
Spying the real repo.groups/repo.admins at module load fails under CI when a
sibling test's mock.module('@fxmanager/database') leaks a partial repo (no
groups) into this file. Mock the module here like the other manager tests so
the test is hermetic and order-independent.
Maximus7474
approved these changes
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This adds some of the largest missing functionality for v1 which is ace permissions and proper group support.
Admins previously had a single per account permission bitmask and groups were just hardcoded presets.
This pretty much replaces that with a db backed group system, a group holds a permission set (name, colour, icon, permission) and each admin is assigned to a group and inherits it, additionally the panel now registers those permissions as ace permissions ingame so we have a 1 to 1 sync between webpanel and ingame.
Tests
Additional Notes
N/A