Fix: core doesn't open setup url in browser#46
Merged
Conversation
FjamZoo
previously approved these changes
Jul 4, 2026
-> mainly those who don't have xdg-open in their path (because don't have a browser - because real server)
Maximus7474
force-pushed
the
fix/setup-open-crashes-linux-distros
branch
from
d919019 to
acd05dc
Compare
FjamZoo
reviewed
Jul 4, 2026
FjamZoo
requested changes
Jul 4, 2026
-> pls stop with these torturous mistakes Maximus
FjamZoo
approved these changes
Jul 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Issue was encountered by users running the panel on a server without a desktop, the open library tries to open the setup panel but fails as it doesn't find the
xdg-openpath causing it to error.This PR addresses it and not only limits the feature to windows but also runs it in a try/catch block.
Tests
Additional Notes