Fix: censor internal convars post load#47
Merged
Conversation
FjamZoo
previously approved these changes
Jul 4, 2026
FjamZoo
previously approved these changes
Jul 4, 2026
FjamZoo
approved these changes
Jul 4, 2026
Maximus7474
force-pushed
the
fix/censor-internal-commands-post-load
branch
from
cd999f6 to
3f4f844
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Convar values (
resource-api-token&api-port) are accessible by clients with thecommandsace permission (generally attributed togroup.adminby tx.This PR addresses this issue by "censoring" the values once they've been loaded into memory by the resource.
Tests
Additional Notes