Fix: leaving page alert on setup when finishing#58
Merged
Conversation
show leaving page alert -> fixes the oversight of 2360b76
andreutu
requested changes
Jul 6, 2026
Co-authored-by: andreutu <91362974+andreutu@users.noreply.github.com>
andreutu
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The commit ( 2360b76 ) introduced showing the "leaving page alert" when the page got refreshed or when leaving.
This used a state to define if it should skip it or not, leading to it not being skipped because it was not a dependency of the effect, using a ref avoids needing to trigger a useless re-render of the page for it.
Tests
Additional Notes