feat: settings enhancement, config manager#8
Merged
Conversation
…r, overhaul getter methods
Maximus7474
requested changes
May 3, 2026
Maximus7474
left a comment
Maximus7474
left a comment
Collaborator
There was a problem hiding this comment.
Looks good at a first read through, will do another more thorough one tomorrow (04/05).
Just these two things atm that pop out.
Maximus7474
requested changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR restructures all database repositories into singleton classes for easier object programming, allowing for method overriding and other OOP features. Admin methods have also been separated from the settings repository, now residing in their own.
Moreover, a new singleton manager has been introduced,
ConfigManager. Despite its "manager" name, it acts more as a cache for settings. At the current point in development, it has an impact in caching values found in environment variables, optionally fetching them from the database:core's webserverTests
Additional Notes
N/A