Conversation
This commit refactors parseMapToStruct by: - extracting helper functions that can be inlined - refactoring and simplifying control flow This refactor does not change encoding or decoding behavior.
fxamacker
force-pushed
the
fxamacker/refactor-parseMapToStruct-etc
branch
from
6f5ad66 to
145a220
Compare
fxamacker
force-pushed
the
fxamacker/refactor-parseMapToStruct-etc
branch
from
145a220 to
48a18bf
Compare
x448
approved these changes
Mar 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors
parseMapToStruct()(was 275 lines) by:Also, this PR refactors
getDecodingStructType()andgetEncodingStructType()for readability.fieldstruct is also refactored intoencodingFieldanddecodingField, so thatencodingFielddoesn't contain any data needed only for decoding, vice versa.This PR does not change encoding or decoding behavior.