Refactor to use slices.SortFunc (Go 1.21+)#774
Merged
Conversation
Behavior of the codec is not affected by this, other than a modest improvement in speed and memory use. This commit replaces the following sort.Interface implementations with slices.SortFunc() to reduce allocs and simplify code: - bytewiseFieldSorter - lengthFirstFieldSorter - indexFieldSorter - bytewiseKeyValueSorter - lengthFirstKeyValueSorter
fxamacker
added
performance
improvement
x448
approved these changes
May 10, 2026
x448
approved these changes
May 10, 2026
fxamacker
changed the base branch from
fxamacker/bump-min-go-version-to-124
to
master
fxamacker
changed the title
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reduces memory allocs and simplifies code by replacing the old
sort.Interfaceimplementations withslices.SortFunc():bytewiseFieldSorterlengthFirstFieldSorterindexFieldSorterbytewiseKeyValueSorterlengthFirstKeyValueSorterThe main benefit is less code to maintain, with the new code being simpler and more modern. The performance improvement in the CBOR codec is modest.