Add initial UPnP support #112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aosmond
force-pushed
the
upnp_rebase
branch
2 times, most recently
from
1d58529 to
8588898
Compare
src/adapters/dummy/mod.rs
Outdated
|
|
||
| impl DummyListener { | ||
| pub fn new() -> Arc<Mutex<Self>> { | ||
| Arc::new(Mutex::new(DummyListener)) |
Contributor
Author
There was a problem hiding this comment.
Maybe it doesn't need to be put in a mutex, similar to how controller and upnp work? (Any data would be protected inside the callback methods of the trait by their own mutex?)
aosmond
force-pushed
the
upnp_rebase
branch
2 times, most recently
from
86b491b to
750a0d1
Compare
aosmond
added a commit
that referenced
this pull request
Mar 7, 2016
Add initial UPnP support. r=dhylands
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.