Merged
Conversation
4678c22 to
0480192
Compare
Collaborator
|
This looks like a great set. I guess we could split up the freeze implementation a bit, but it is a tricky piece of code, and I am not sure these sign posts would be sufficient. |
Collaborator
Author
|
I find the code pretty readable, and therefore the markers sufficient, but this is very likely due to too much kool-aid |
e653d9b to
2c90688
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds markers for the artifact, the output roughly looks like this:
@mjp41 Are there any interesting implementation details I forgot?