How to test correctly (before opening a pull request)?

[MaxGyver83]

CONTRIBUTING.md says:

4. Run the tests and make sure everything still works as expected using go test ./....

But when I run this command on the develop branch, some tests fail, p.e.:

FAIL	fyne.io/fyne/v2/internal/driver/mobile	3.414s

When I run this test with mobile tag added, it succeeds:

go test -tags mobile ./internal/driver/mobile

What is correct? With or without -tags mobile?

After creating a pull request, the CI runs these tests:

go test -race -tags "ci,migrated_fynedo" ./...
go test -race -tags mobile,ci,migrated_fynedo ./...

Both succeed on my laptop.

Which tests should I run and which ones must pass before I create a pull request?

[andydotxyz]

But when I run this command on the develop branch, some tests fail, p.e.:

FAIL fyne.io/fyne/v2/internal/driver/mobile 3.414s
When I run this test with mobile tag added, it succeeds:

go test -tags mobile ./internal/driver/mobile
What is correct? With or without -tags mobile?

Both :) the tests in mobile package should pass without mobile flag (for sake of avoiding exclusions in path list) and with mobile tag you're testing the Android/iOS build.

After creating a pull request, the CI runs these tests:

go test -race -tags "ci,migrated_fynedo" ./...
go test -race -tags mobile,ci,migrated_fynedo ./...

Yup, the "ci" tag is for items that cannot be run on a headless Linux server.

But feel free to open a PR with a failing test - just don't tick the "tests pass" and note what the issue is.