Add form validation#6323
Draft
andydotxyz wants to merge 9 commits into
Draft
Conversation
Any widget implementing Requirable can be marked as Required.
And tests that were not logically consistent
a49c3a3 to
9d1a0a3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding Form.Validator to check the whole of a form and control if Submit is enabled.
(this is built on top of
FormItem.Requiredto avoid conflicts)Tests still to be included (- and balance the old entry validation specifics with this), PR is open for feedback just now, try this code:
Fixes #2562
Checklist: