Skip to content

Fix error message when signing with duplicate tx_id (Issue #60) #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anhthii merged 2 commits into from
Jul 30, 2025
Merged

Fix error message when signing with duplicate tx_id (Issue #60) #63

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6c84341
Fix error message when signing with duplicate tx id
Azzurriii Jul 30, 2025
4e27bea
Update error message for duplicate signing requests to be more concise
Azzurriii Jul 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions pkg/event/types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,8 @@ func GetErrorCodeFromError(err error) ErrorCode {
return ErrorCodeContextCancelled
case contains(errStr, "invalid signature from initiator"):
return ErrorCodeInvalidInitiatorSignature
case contains(errStr, "duplicate"):
return ErrorCodeSessionDuplicate
default:
return ErrorCodeUnknown
}
Expand Down
9 changes: 9 additions & 0 deletions pkg/eventconsumer/event_consumer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,6 +323,15 @@ func (ec *eventConsumer) consumeTxSigningEvent() error {

// Check for duplicate session and track if new
if ec.checkDuplicateSession(msg.WalletID, msg.TxID) {
duplicateErr := fmt.Errorf("duplicate signing request detected for walletID=%s txID=%s", msg.WalletID, msg.TxID)
ec.handleSigningSessionError(
msg.WalletID,
msg.TxID,
msg.NetworkInternalCode,
duplicateErr,
"Duplicate session",
natMsg,
)
return
}

Expand Down
Loading