fix typo #64
fix typo #64
Conversation
|
|
||
| 1. **Distributed Trust**: No single entity possesses complete private keys | ||
| 2. **Threshold Cryptography**: Requires t+1 nodes to participate in signing operations | ||
| 2. **Threshold Cryptography**: Requires t-out-of-n nodes to participate in signing operations |
There was a problem hiding this comment.
hi @nann-cheng , thanks for the PR. I think we need to say that it require at least t+1 node to paricipate in signing. t-out-of-n might be incorrect. wdyt?
There was a problem hiding this comment.
Sometimes the concept of t depends on the context, in the image it indicates the allowed amount of corrupted adversaries, from your README.md, seems you are defining t as the threshold of Shamir secret sharing scheme
I am trying to make it consistent, i need to see closely how tss-lib defines t in their doc, though, hold on
There was a problem hiding this comment.
my bad, could be an inconsistency mistake from my end
There was a problem hiding this comment.
yeah you are right. it depends on the context. I think we might need to change the definition in the readme.md
2 out of 3 threshold means t = 1
There was a problem hiding this comment.
Different researchers tend to define the t differently:
I myself prefer this one, and Binance tss-lib is based from this paper
This is why you got inconsistency in the first place, do whatever the way you like, but I personally like the first definition, the t definition in your code is also following the t definition in original README.md
There was a problem hiding this comment.
ok let's go with this. thanks for the PR @nann-cheng
2 participants
fix small typos