Conversation
2.add empty method
| } | ||
|
|
||
| /** | ||
| * @see org.springframework.util.StringUtils#trimLeadingWhitespace(String) |
There was a problem hiding this comment.
MissingSummary: A summary fragment is required; consider using the value of the @see block as a summary fragment instead.
| * @see org.springframework.util.StringUtils#trimLeadingWhitespace(String) | |
| *See {@link org.springframework.util.StringUtils#trimLeadingWhitespace(String)}. |
(at-me in a reply with help or ignore)
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
| } | ||
|
|
||
| /** | ||
| * @see org.springframework.util.StringUtils#capitalize |
There was a problem hiding this comment.
MissingSummary: A summary fragment is required; consider using the value of the @see block as a summary fragment instead.
| * @see org.springframework.util.StringUtils#capitalize | |
| *See {@link org.springframework.util.StringUtils#capitalize}. |
(at-me in a reply with help or ignore)
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
| } | ||
|
|
||
| /** | ||
| * @see org.springframework.util.StringUtils#unqualify |
There was a problem hiding this comment.
MissingSummary: A summary fragment is required; consider using the value of the @see block as a summary fragment instead.
| * @see org.springframework.util.StringUtils#unqualify | |
| *See {@link org.springframework.util.StringUtils#unqualify}. |
(at-me in a reply with help or ignore)
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
| } | ||
|
|
||
| /** | ||
| * @see org.springframework.util.StringUtils#uncapitalize |
There was a problem hiding this comment.
MissingSummary: A summary fragment is required; consider using the value of the @see block as a summary fragment instead.
| * @see org.springframework.util.StringUtils#uncapitalize | |
| *See {@link org.springframework.util.StringUtils#uncapitalize}. |
(at-me in a reply with help or ignore)
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
| } | ||
|
|
||
| /** | ||
| * @return {@link List }<{@link T }> |
There was a problem hiding this comment.
MissingSummary: A summary line is required on public/protected Javadocs.
(at-me in a reply with help or ignore)
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
| } | ||
|
|
||
| /** | ||
| * @apiNote the value is {@code <T> } |
There was a problem hiding this comment.
MissingSummary: A summary fragment is required; consider using the value of the @see block as a summary fragment instead.
| * @apiNote the value is {@code <T> } | |
| *See {@link #toMap(Seq, Function, Function)}. |
(at-me in a reply with help or ignore)
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
| } | ||
|
|
||
| /** | ||
| * @see #sort(Collection, Comparator) |
There was a problem hiding this comment.
MissingSummary: A summary fragment is required; consider using the value of the @see block as a summary fragment instead.
| * @see #sort(Collection, Comparator) | |
| *See {@link #sort(Collection, Comparator)}. |
(at-me in a reply with help or ignore)
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
| * | ||
| * @apiNote this method is a shortcut for {@code collect(Collectors.toMap(keyMapper, valueMapper))}, | ||
| */ | ||
| default <K, V> Map<K, V> toMap(final Function<? super T, ? extends K> keyMapper, |
There was a problem hiding this comment.
AmbiguousMethodReference: This method's reference is ambiguous, its name and functional interface type are the same as: toMap(Seq, Function<? super T, ? extends K>, Function<? super T, ? extends V>)
(at-me in a reply with help or ignore)
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
| } | ||
|
|
||
| /** | ||
| * @see #sort(Collection, Comparator) |
There was a problem hiding this comment.
MissingSummary: A summary fragment is required; consider using the value of the @see block as a summary fragment instead.
| * @see #sort(Collection, Comparator) | |
| *See {@link #sort(Collection, Comparator)}. |
(at-me in a reply with help or ignore)
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
| } | ||
|
|
||
| /** | ||
| * @see org.springframework.util.StringUtils#countOccurrencesOf |
There was a problem hiding this comment.
MissingSummary: A summary fragment is required; consider using the value of the @see block as a summary fragment instead.
| * @see org.springframework.util.StringUtils#countOccurrencesOf | |
| *See {@link org.springframework.util.StringUtils#countOccurrencesOf}. |
(at-me in a reply with help or ignore)
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
| } | ||
|
|
||
| /** | ||
| * @see org.springframework.util.StringUtils#trimWhitespace(String) |
There was a problem hiding this comment.
MissingSummary: A summary fragment is required; consider using the value of the @see block as a summary fragment instead.
| * @see org.springframework.util.StringUtils#trimWhitespace(String) | |
| *See {@link org.springframework.util.StringUtils#trimWhitespace(String)}. |
(at-me in a reply with help or ignore)
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
| * @apiNote <pre> | ||
| * 1. startWith : | ||
| * 2. startWith * | ||
| * 3. startWith { && endWith } |
There was a problem hiding this comment.
UnescapedEntity: This HTML entity is invalid. Enclosing the code in this
/ tag with a {@code } block will force Javadoc to interpret HTML literally.
* @apiNote <pre>{@code
(at-me in a reply with help or ignore)
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
| } | ||
|
|
||
| /** | ||
| * @see org.springframework.util.StringUtils#delete |
There was a problem hiding this comment.
MissingSummary: A summary fragment is required; consider using the value of the @see block as a summary fragment instead.
| * @see org.springframework.util.StringUtils#delete | |
| *See {@link org.springframework.util.StringUtils#delete}. |
(at-me in a reply with help or ignore)
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
| * @apiNote the value is {@code <T> } | ||
| * @see #toMap(Seq, Function, Function) | ||
| */ | ||
| default <K> Map<K, T> toMap(final Function<? super T, ? extends K> keyMapper) { |
There was a problem hiding this comment.
AmbiguousMethodReference: This method's reference is ambiguous, its name and functional interface type are the same as: toMap(Seq, Function<T, K>)
(at-me in a reply with help or ignore)
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
| } | ||
|
|
||
| /** | ||
| * @apiNote the value is {@code <T> } |
There was a problem hiding this comment.
MissingSummary: A summary fragment is required; consider using the value of the @see block as a summary fragment instead.
| * @apiNote the value is {@code <T> } | |
| *See {@link #toMap(Seq, Function, Function)}. |
(at-me in a reply with help or ignore)
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
| } | ||
|
|
||
| /** | ||
| * @see org.springframework.util.StringUtils#startsWithIgnoreCase |
There was a problem hiding this comment.
MissingSummary: A summary fragment is required; consider using the value of the @see block as a summary fragment instead.
| * @see org.springframework.util.StringUtils#startsWithIgnoreCase | |
| *See {@link org.springframework.util.StringUtils#startsWithIgnoreCase}. |
(at-me in a reply with help or ignore)
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
| } | ||
|
|
||
| /** | ||
| * @see org.springframework.util.StringUtils#unqualify(String, char) |
There was a problem hiding this comment.
MissingSummary: A summary fragment is required; consider using the value of the @see block as a summary fragment instead.
| * @see org.springframework.util.StringUtils#unqualify(String, char) | |
| *See {@link org.springframework.util.StringUtils#unqualify(String, char)}. |
(at-me in a reply with help or ignore)
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
| * default impl | ||
| * | ||
| * @apiNote support<pre> | ||
| * 1./hello/:name -> get name |
There was a problem hiding this comment.
UnescapedEntity: This HTML entity is invalid. Enclosing the code in this
/ tag with a {@code } block will force Javadoc to interpret HTML literally.
* @apiNote support<pre>{@code
(at-me in a reply with help or ignore)
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
| } | ||
|
|
||
| /** | ||
| * @see org.springframework.util.StringUtils#endsWithIgnoreCase |
There was a problem hiding this comment.
MissingSummary: A summary fragment is required; consider using the value of the @see block as a summary fragment instead.
| * @see org.springframework.util.StringUtils#endsWithIgnoreCase | |
| *See {@link org.springframework.util.StringUtils#endsWithIgnoreCase}. |
(at-me in a reply with help or ignore)
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
| } | ||
|
|
||
| /** | ||
| * @apiNote the value is {@code <T> } |
There was a problem hiding this comment.
MissingSummary: A summary fragment is required; consider using the value of the @see block as a summary fragment instead.
| * @apiNote the value is {@code <T> } | |
| *See {@link #toMap(Seq, Function, Function)}. |
(at-me in a reply with help or ignore)
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
| } | ||
|
|
||
| /** | ||
| * @see org.springframework.util.StringUtils#trimAllWhitespace(String) |
There was a problem hiding this comment.
MissingSummary: A summary fragment is required; consider using the value of the @see block as a summary fragment instead.
| * @see org.springframework.util.StringUtils#trimAllWhitespace(String) | |
| *See {@link org.springframework.util.StringUtils#trimAllWhitespace(String)}. |
(at-me in a reply with help or ignore)
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
| } | ||
|
|
||
| /** | ||
| * @see org.springframework.util.StringUtils#replace |
There was a problem hiding this comment.
MissingSummary: A summary fragment is required; consider using the value of the @see block as a summary fragment instead.
| * @see org.springframework.util.StringUtils#replace | |
| *See {@link org.springframework.util.StringUtils#replace}. |
(at-me in a reply with help or ignore)
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
| import cn.hutool.core.codec.PercentCodec; | ||
|
|
||
| /** | ||
| * @author <a href="mailto:likelovec@gmail.com">fzdwx</a> |
There was a problem hiding this comment.
MissingSummary: A summary line is required on public/protected Javadocs.
(at-me in a reply with help or ignore)
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
| } | ||
|
|
||
| /** | ||
| * @apiNote the value is {@code <T> } |
There was a problem hiding this comment.
MissingSummary: A summary fragment is required; consider using the value of the @see block as a summary fragment instead.
| * @apiNote the value is {@code <T> } | |
| *See {@link #toMap(Seq, Function, Function)}. |
(at-me in a reply with help or ignore)
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
| } | ||
|
|
||
| /** | ||
| * @see org.springframework.util.StringUtils#deleteAny |
There was a problem hiding this comment.
MissingSummary: A summary fragment is required; consider using the value of the @see block as a summary fragment instead.
| * @see org.springframework.util.StringUtils#deleteAny | |
| *See {@link org.springframework.util.StringUtils#deleteAny}. |
(at-me in a reply with help or ignore)
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
| } | ||
|
|
||
| /** | ||
| * @see #sort(Collection, Comparator) |
There was a problem hiding this comment.
MissingSummary: A summary fragment is required; consider using the value of the @see block as a summary fragment instead.
| * @see #sort(Collection, Comparator) | |
| *See {@link #sort(Collection, Comparator)}. |
(at-me in a reply with help or ignore)
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
| } | ||
|
|
||
| /** | ||
| * @apiNote the value is {@code <T> } |
There was a problem hiding this comment.
MissingSummary: A summary fragment is required; consider using the value of the @see block as a summary fragment instead.
| * @apiNote the value is {@code <T> } | |
| *See {@link #toMap(Seq, Function, Function)}. |
(at-me in a reply with help or ignore)
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
| while ((charsRead = reader.read(buffer)) != -1) { | ||
| out.append(buffer, 0, charsRead); | ||
| } | ||
| return out.toString(); |
There was a problem hiding this comment.
RESOURCE_LEAK: resource of type java.io.InputStreamReader acquired by call to new() at line 76 is not released after line 82.
(at-me in a reply with help or ignore)
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
| } | ||
|
|
||
| /** | ||
| * @see org.springframework.util.StringUtils#trimTrailingWhitespace(String) |
There was a problem hiding this comment.
MissingSummary: A summary fragment is required; consider using the value of the @see block as a summary fragment instead.
| * @see org.springframework.util.StringUtils#trimTrailingWhitespace(String) | |
| *See {@link org.springframework.util.StringUtils#trimTrailingWhitespace(String)}. |
(at-me in a reply with help or ignore)
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
| } | ||
|
|
||
| /** | ||
| * @apiNote the value is {@code <T> } |
There was a problem hiding this comment.
MissingSummary: A summary fragment is required; consider using the value of the @see block as a summary fragment instead.
| * @apiNote the value is {@code <T> } | |
| *See {@link #toMap(Seq, Function, Function)}. |
(at-me in a reply with help or ignore)
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
| Assert.nonNull(charset, "charset not found."); | ||
| Writer writer = new OutputStreamWriter(out, charset); | ||
| writer.write(in); | ||
| writer.flush(); |
There was a problem hiding this comment.
RESOURCE_LEAK: resource of type java.io.OutputStreamWriter acquired by call to new() at line 109 is not released after line 111.
(at-me in a reply with help or ignore)
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
| if (collection == null) { | ||
| return Collections.map(); | ||
| } | ||
| return toMap(Seq.of(collection), keyMapper, valueMapper); |
There was a problem hiding this comment.
RESOURCE_LEAK: resource of type io.github.fzdwx.lambada.internal.SeqImpl acquired by call to of(...) at line 249 is not released after line 249.
(at-me in a reply with help or ignore)
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
| while ((charsRead = reader.read(buffer)) != -1) { | ||
| out.append(buffer, 0, charsRead); | ||
| } | ||
| return out.toString(); |
There was a problem hiding this comment.
RESOURCE_LEAK: resource of type java.io.InputStreamReader acquired to reader by call to new() at line 76 is not released after line 82.
Note: potential exception at line 79
(at-me in a reply with help or ignore)
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
| if (stream == null) { | ||
| return Collections.map(); | ||
| } | ||
| return toMap(Seq.of(stream), keyMapper, valueMapper); |
There was a problem hiding this comment.
RESOURCE_LEAK: resource of type io.github.fzdwx.lambada.internal.SeqImpl acquired by call to of(...) at line 276 is not released after line 276.
(at-me in a reply with help or ignore)
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
| Writer writer = new OutputStreamWriter(out, charset); | ||
| writer.write(in); | ||
| writer.flush(); | ||
| } |
There was a problem hiding this comment.
RESOURCE_LEAK: resource of type java.io.OutputStreamWriter acquired by call to new() at line 109 is not released after line 112.
Note: potential exception at line 110
(at-me in a reply with help or ignore)
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
| if (Lang.isEmpty(collection)) { | ||
| return Collections.map(); | ||
| } | ||
| return toMap(Seq.of(collection), keyMapper, Function.identity()); |
There was a problem hiding this comment.
RESOURCE_LEAK: resource of type io.github.fzdwx.lambada.internal.SeqImpl acquired by call to of(...) at line 235 is not released after line 235.
(at-me in a reply with help or ignore)
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
| if (stream == null) { | ||
| return Collections.map(); | ||
| } | ||
| return toMap(Seq.of(stream), keyMapper, Function.identity()); |
There was a problem hiding this comment.
RESOURCE_LEAK: resource of type io.github.fzdwx.lambada.internal.SeqImpl acquired by call to of(...) at line 262 is not released after line 262.
(at-me in a reply with help or ignore)
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
release 0.10.4