Issue 29a: errors when no object or group specified #116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…file can be found and when no materials are specified in the OBJ file.
…de. added default material defined in 1 location.
object (o) and group (g) lines are optional in OBJ. the parser doesn't create a group if these lines are not present, which breaks parsing of face and usemtl lines. I added checks to create 'default' groups when first encountering a usemtl or face line if no group or object was created.
DecodeReader() will try the io.Reader first, then the mtllib file in the OBJ, if present. If all else fails, a default material is applied. DecodeReader() produces no error for materials.
Merge branch 'issue-29-obj-default-mat' into issue-29-handle-no-groups
Closed
Member
|
Merged! 😄 |
uzudil
pushed a commit
to uzudil/engine
that referenced
this pull request
Dec 16, 2020
Issue 29a: errors when no object or group specified
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #29, I used some OBJs with geometry defined not using object (o) or group (g) lines. Apparently these are also optional in the OBJ format. In the case when a file does not have an
oorgspecified, a nil-pointer error is encountered atdec.objCurrentinparseFace(), as it assume a group is made previously via theparseObject()method.To protect against this, basically just made a group
unnamed###. I also pulled the creation ofobj.Objectout into a private func because I thought I'd have to call it from multiple places (I didn't need to, but it may be useful down the road).