fix(parser): Phase 3 parse bug — Result( typo in operations.t27, watcher.t27#392
Merged
Conversation
…her.t27 Closes #388 Three instances of Result( instead of Result< caused 'Expected RBrace, got Eof': - specs/file/operations.t27 line 82: list() return type - specs/file/operations.t27 line 87: list_recursive() return type - specs/file/watcher.t27 line 46: get_watched_paths() return type After fix: all specs in specs/ parse successfully (zero failures).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #388 —
specs/file/operations.t27andspecs/file/watcher.t27failed to parse withExpected RBrace, got Eof.Root cause: three instances of
Result(instead ofResult<:operations.t27:82—fn listreturn typeoperations.t27:87—fn list_recursivereturn typewatcher.t27:46—fn get_watched_pathsreturn typeAfter fix: all specs in
specs/parse successfully (zero failures).Test plan
t27c parse specs/file/operations.t27— passest27c parse specs/file/watcher.t27— passest27c gen-verilogboth files — passest27c seal --saveboth files — passes.t27specs — 0 failures