feat(gen-c): [T; N] lowers to a by-value struct; untyped literal locals pinned - #1947
Merged
Conversation
…ls pinned Closes #1944 C cannot return arrays, so [T; N] now lowers uniformly to a by-value struct (typedef struct { T v[N]; } t27_arr_T_N): params (were T*), returns (were invalid C), array literals ((T){ .v = { ... } }), locals and indexing (.v[i]) all move together. Sizes canonicalize through module consts so [u32; MAX_METRICS] and [u32; 16] share one nominal type; test bindings and untyped locals infer the struct type from the called fn's return type. Also: untyped integer-literal locals pin uint32_t/uint64_t instead of C's signed int -- 0xFFFFFFFF as int is -1 and every unsigned comparison against it inverts (the C twin of the Zig comptime_int fix; found live in energy_aware_routing's min-cost search). tri-net corpus: C execution 54 -> 69/69 (full corpus). One genuine spec type mismatch surfaced (api_documenter passed [u32; 64] where [u32; 16] belongs) -- fixed tri-net-side. FROZEN_HASH resealed; only unit red is the pre-existing bitnet_layer iverilog test. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
gHashTag
enabled auto-merge (squash)
August 8, 2026 16:17
Contributor
Contributor
|
📓 NotebookLM Notebook linked to this PR
This notebook contains session context, decisions, and artifacts for this work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1944
C cannot return arrays:
[T; N]now lowers uniformly to a by-value struct (typedef struct { T v[N]; } t27_arr_T_N;) — params (wereT*), returns (were invalid C), literals ((T){ .v = { ... } }), locals and indexing (.v[i]) move together. Sizes canonicalize through module consts ([u32; MAX_METRICS]≡[u32; 16]); bindings infer the struct from the called fn's return type.Also: untyped integer-literal locals pin uint32_t/uint64_t instead of C's signed int —
0xFFFFFFFFas int is −1 and unsigned comparisons invert (the C twin of the Zig comptime_int fix; found live in energy_aware_routing).tri-net corpus: C execution 54 → 69/69 (full corpus); one genuine spec type mismatch surfaced (api_documenter), fixed tri-net-side. Only unit red is pre-existing bitnet_layer. FROZEN_HASH resealed; NOW.md entries added.
🤖 Generated with Claude Code